New issue
Advanced search Search tips

Issue 909750 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
pdr@chromium.org
bokan@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[CompositeAfterPaint] Switch all usages of viewport layers to use viewport property ids

Project Member Reported by wangxianzhu@chromium.org, Nov 28 
We don't create viewport layers in CompositeAfterPaint. For now cc gets information of viewport from the viewport layers. https://chromium-review.googlesource.com/c/chromium/src/+/1352322 is the first step which switches one usage of PageScaleLayer to page scale transform id. We need to check all other callers of PageScaleLayer() to switch to page scale transform id if needed, as well as other callers of viewport layer getters.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb746a5c826f771ce4a35e2dffefee5c19cf0966

commit eb746a5c826f771ce4a35e2dffefee5c19cf0966
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Nov 29 04:07:19 2018

[CompositeAfterPaint] Let cc know the viewport page scale transform node

Bug:  726066 , 909750
Change-Id: I12242ad3facdc7e8877833d2c436e383f2c9530f
Reviewed-on: https://chromium-review.googlesource.com/c/1352322
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612030}
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/cc/trees/layer_tree_host.h
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.h
[modify] https://crrev.com/eb746a5c826f771ce4a35e2dffefee5c19cf0966/third_party/blink/web_tests/FlagExpectations/enable-slimming-paint-v2
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6

commit 9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Dec 11 20:31:04 2018

[CompositeAfterPaint] Pass inner viewport scroll node to cc

Bug: 909750
Change-Id: I10ff2ec0f58cddfd16c28d47de153ce484a6833c
Reviewed-on: https://chromium-review.googlesource.com/c/1370497
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615649}
[modify] https://crrev.com/9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6/cc/trees/layer_tree_host.h
[modify] https://crrev.com/9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.h
[modify] https://crrev.com/9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6/third_party/blink/web_tests/FlagExpectations/enable-blink-features=CompositeAfterPaint
[modify] https://crrev.com/9dfcafe0f110f29ce6ba2df8cf0d12074599e0c6/third_party/blink/web_tests/TestExpectations
►

Sign in to add a comment