1. Color of UI highlight for overflow menu Google Blue 600 (#1A73E8), 10% 2. Colored overflow menu icon Google Blue 600 2. For dark themed backgrounds, Google Grey 100,30% Spec: https://docs.google.com/presentation/d/1A9QtE_cxJYLs3E7fQs9-tiCtLfEwxQiYDZUMYkYVHmI/edit#slide=id.g338d2b5135_0_4
1. Color of UI highlight for overflow menu Google Blue 600 (#1A73E8), 10% 2. Colored overflow menu icon Google Blue 600 3. For dark themed backgrounds, Google Grey 100,30% Spec: https://docs.google.com/presentation/d/1A9QtE_cxJYLs3E7fQs9-tiCtLfEwxQiYDZUMYkYVHmI/edit#slide=id.g338d2b5135_0_4 4. Next step highlight color is GB600,10% https://docs.google.com/presentation/d/1A9QtE_cxJYLs3E7fQs9-tiCtLfEwxQiYDZUMYkYVHmI/edit#slide=id.g338d2b5135_0_44
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/982e81b1100ce582ae2a79aca36ae30db9455719 commit 982e81b1100ce582ae2a79aca36ae30db9455719 Author: Collin Baker <collinbaker@chromium.org> Date: Tue Dec 11 23:58:49 2018 Implement blue app menu button highlight for in-product help Bug: 909747 Change-Id: I4f7f9d6a34242d7dec8b343ff38aaa2b05019cec Reviewed-on: https://chromium-review.googlesource.com/c/1362190 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#615731} [modify] https://crrev.com/982e81b1100ce582ae2a79aca36ae30db9455719/chrome/browser/feature_engagement/incognito_window/incognito_window_tracker.cc [modify] https://crrev.com/982e81b1100ce582ae2a79aca36ae30db9455719/chrome/browser/ui/views/feature_promos/reopen_tab_promo_controller.cc [modify] https://crrev.com/982e81b1100ce582ae2a79aca36ae30db9455719/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc [modify] https://crrev.com/982e81b1100ce582ae2a79aca36ae30db9455719/chrome/browser/ui/views/toolbar/browser_app_menu_button.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4 commit 9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4 Author: Collin Baker <collinbaker@chromium.org> Date: Wed Jan 09 23:08:14 2019 Implement blue menu item alerts for in-product help An alert state is added to MenuItemView, which pulls a new background color from the NativeTheme in this state. The alert state is managed by MenuController which is handed a delegate to determine if a given item should be alerted. This alert state is used for reopen tab in-product help through AppMenu. Bug: 909747 Change-Id: I728dc91240d28fdf8668b1d76f81f8323d9ea842 Reviewed-on: https://chromium-review.googlesource.com/c/1387985 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#621358} [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/chrome/browser/ui/libgtkui/native_theme_gtk.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/chrome/browser/ui/toolbar/app_menu_model.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/chrome/browser/ui/views/feature_promos/reopen_tab_promo_controller.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/chrome/browser/ui/views/feature_promos/reopen_tab_promo_controller.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/chrome/browser/ui/views/toolbar/app_menu.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/chrome/browser/ui/views/toolbar/app_menu.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/chrome/browser/ui/views/toolbar/app_menu_observer.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/native_theme/common_theme.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/native_theme/native_theme.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/native_theme/native_theme_dark_aura.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_controller.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_controller.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_item_view.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_item_view.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner_impl.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner_impl.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner_impl_adapter.cc [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner_impl_adapter.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner_impl_cocoa.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner_impl_cocoa.mm [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner_impl_interface.h [modify] https://crrev.com/9947dc4fe9296b5083ec4f4378c9a8f0150d6cd4/ui/views/controls/menu/menu_runner_unittest.cc
Dark theme stuff was split off to https://crbug.com/920027 so marking this as done.
Comment 1 by namratakannan@chromium.org
, Nov 28