New issue
Advanced search Search tips

Issue 909740 link

Starred by 1 user
Status: Fixed
Owner:
collinbaker@chromium.org
Closed: Jan 15
Cc:
cyflee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 910354



Sign in to add a comment

[Navi] Desktop IPH Pilot: UI changes for IPH bubble

Project Member Reported by namratakannan@chromium.org, Nov 28 
1. Height of the bubble is 44px
2. Background color of the bubble Google Blue 700 (#1967D2)
3. Dropshadow #3C4043, 15% (0,1,2,0)
              #3C4043, 30% (0,4,8,3)

Spec: 
https://docs.google.com/presentation/d/1A9QtE_cxJYLs3E7fQs9-tiCtLfEwxQiYDZUMYkYVHmI/edit#slide=id.g338d2b5135_0_19

Comment 1 by namratakannan@chromium.org, Nov 28

Cc: cyflee@chromium.org

Comment 2 by robliao@chromium.org, Nov 29

Labels: Type-Feature

Comment 3 by cyflee@chromium.org, Nov 29

Labels: -Proj-Navi Proj-Navi-IPH

Comment 4 by cyflee@chromium.org, Nov 29

Labels: -Proj-Navi-IPH Navi-IPH

Comment 5 by cyflee@chromium.org, Nov 29

Labels: -Navi-IPH proj-IPH

Comment 6 by collinbaker@chromium.org, Nov 29

Status: Assigned (was: Untriaged)

Comment 7 by cyflee@chromium.org, Dec 3

Blocking: 910354
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5356fbeacd2083c26d3ad5c303d5fee0cf408228

commit 5356fbeacd2083c26d3ad5c303d5fee0cf408228
Author: Collin Baker <collinbaker@chromium.org>
Date: Fri Dec 07 22:00:51 2018

Change corner radius and dimensions for in-product help promo bubbles

Bug:  909740 
Change-Id: Iffe0d9f944765f313edd50138dd07d32db653e64
Reviewed-on: https://chromium-review.googlesource.com/c/1362299
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614834}
[modify] https://crrev.com/5356fbeacd2083c26d3ad5c303d5fee0cf408228/chrome/browser/ui/views/feature_promos/feature_promo_bubble_view.cc

Comment 9 by collinbaker@chromium.org, Jan 15

Status: Fixed (was: Assigned)
I'm marking this as done. Any additional changes for beta onward can go in separate issues.
►

Sign in to add a comment