New issue
Advanced search Search tips

Issue 909734 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fix ProfileDowloader::OnRefreshTokenUpdatedForAccount()

Project Member Reported by blundell@chromium.org, Nov 28

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/1163620/ migrated ProfileDownloader to IdentityManager. As part of doing so, it naturally checked the |is_valid| parameter in ProfileDownloader::OnRefreshTokenUpdatedForAccount(). However, this check is actually incorrect, as the being migrated *away from* was not making the equivalent check (which would have been checking PO2TS::GetAuthError() explicitly). I discovered this while going through the codebase to remove the |is_valid| parameter from this observer callback precisely to avoid this kind of confusion :).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b3b41826eb2064ddfb96b61c3c6165659bb379d

commit 6b3b41826eb2064ddfb96b61c3c6165659bb379d
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Nov 29 15:16:53 2018

Remove usage of is_valid from ProfileDownloader's token update callback

https://chromium-review.googlesource.com/c/chromium/src/+/1163620/
migrated ProfileDownloader to IdentityManager. As part of doing so, it
naturally checked the |is_valid| parameter in ProfileDownloader::
OnRefreshTokenUpdatedForAccount(). However, this check is actually
incorrect, as the being migrated *away from* was not making the
equivalent check (which would have been checking PO2TS::GetAuthError()
explicitly). I discovered this while going through the codebase to
remove the |is_valid| parameter from this observer callback precisely
to avoid this kind of confusion :).

Bug: 909734
Change-Id: Iace1fbe14326aedbdd54e6e59db9ec466d8ffcdc
Reviewed-on: https://chromium-review.googlesource.com/c/1353982
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612196}
[modify] https://crrev.com/6b3b41826eb2064ddfb96b61c3c6165659bb379d/chrome/browser/profiles/profile_downloader.cc

Sign in to add a comment