https://chromium-review.googlesource.com/c/chromium/src/+/1163620/ migrated ProfileDownloader to IdentityManager. As part of doing so, it naturally checked the |is_valid| parameter in ProfileDownloader::OnRefreshTokenUpdatedForAccount(). However, this check is actually incorrect, as the being migrated *away from* was not making the equivalent check (which would have been checking PO2TS::GetAuthError() explicitly). I discovered this while going through the codebase to remove the |is_valid| parameter from this observer callback precisely to avoid this kind of confusion :).
Comment 1 by bugdroid1@chromium.org
, Nov 29