New issue
Advanced search Search tips

Issue 909730 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[AF] Add then remove a profile

Project Member Reported by parastoog@chromium.org, Nov 28

Issue description

In the personal data manager tests:

If you add a profile and then remove it right away, the profile will not be removed, because at the time that personal data manager looks for the profile, it doesn't exist yet.

https://codesearch.chromium.org/chromium/src/components/autofill/core/browser/personal_data_manager.cc?sq=package:chromium&dr&g=0&l=1067
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cace0c5651e73ef371fe785db9a52741e6ccf97

commit 6cace0c5651e73ef371fe785db9a52741e6ccf97
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Wed Nov 28 23:15:56 2018

[AF] add then remove a profile/test.

To show that this case is not currently supported.

Bug:  909730 
Change-Id: Iaca51858fa9987ef95cd9c4341386472dc55cb57
Reviewed-on: https://chromium-review.googlesource.com/c/1352507
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611926}
[modify] https://crrev.com/6cace0c5651e73ef371fe785db9a52741e6ccf97/components/autofill/core/browser/personal_data_manager_unittest.cc

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a67026e0dcd194cded0c9d086a7b07e114aa382

commit 9a67026e0dcd194cded0c9d086a7b07e114aa382
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Mon Jan 07 15:10:59 2019

[AF] Schedule Add/Remove/Update profiles

Keep a timely ordered list of requested operations on profiles.
For each profile, start the next operation when the previous one
finishes on the database.

Also, profile_validities_need_update_ will be updated only for
add/update.
Note: For different profiles, there is no overlap, therefore,
operations can be handled in parallel. This is especially useful for
async tasks such as client side validation.

Bug:  909730 
Change-Id: I822648a71e7cfd815461149645d3411f6d08ba9e
Reviewed-on: https://chromium-review.googlesource.com/c/1372175
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#620323}
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/chrome/browser/autofill/autofill_browsertest.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/chrome/browser/sync/test/integration/autofill_helper.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/chrome/browser/sync/test/integration/autofill_helper.h
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/form_data_importer_unittest.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/personal_data_manager_observer.h
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/webdata/autofill_change.h
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/webdata/autofill_webdata_service.cc
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/webdata/autofill_webdata_service.h
[modify] https://crrev.com/9a67026e0dcd194cded0c9d086a7b07e114aa382/components/autofill/core/browser/webdata/autofill_webdata_service_observer.h

Status: Fixed (was: Started)

Sign in to add a comment