Unbound WebAPK prompts user to select host browser twice |
|
Issue descriptionRepro steps: 1) Flash Android O onto an Android 6P device (This bug does not repro on the Android Go device or the Samsung Galaxy Prime devices that I tried) 2) Install a version of Chrome compiled with android_default_version_name = "2147483647." 3) Change NewSplashWebApk.apk to use unbound_manifest_config.json 4) Compile NewSplashWebApk.apk 5) Install NewSplashWebApk.apk (Make sure that the APK is not already installed) 6) Launch NewSplashWebApk.apk Expected: Shown dialog to select host browser once Actual: Shown dialog to select host browser twice
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abde41ca8b36464f7340b0d107f8e83a1ade3151 commit abde41ca8b36464f7340b0d107f8e83a1ade3151 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Tue Dec 04 17:11:57 2018 [Android WebAPK] Fix host-browser-selection dialog appearing twice for NewSplashWebApk This CL fixes a bug where the host-browser-selection dialog would appear twice for unbound WebAPKs on some devices. This was caused by PackageManager#setComponentEnabledSetting() killing the WebAPK prior to the shared preferences being written to disk. This CL ensures that the shared preferences have been written to disk prior to calling PackageManager#setComponentEnabledSetting() BUG=909714 Change-Id: Id99d32d1777f890fa4825b980bbddc83a4113161 Reviewed-on: https://chromium-review.googlesource.com/c/1354059 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#613580} [modify] https://crrev.com/abde41ca8b36464f7340b0d107f8e83a1ade3151/chrome/android/webapk/shell_apk/current_version/current_version.gni [modify] https://crrev.com/abde41ca8b36464f7340b0d107f8e83a1ade3151/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserUtils.java [modify] https://crrev.com/abde41ca8b36464f7340b0d107f8e83a1ade3151/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSharedPreferences.java [modify] https://crrev.com/abde41ca8b36464f7340b0d107f8e83a1ade3151/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/h2o/H2OLauncher.java |
|
►
Sign in to add a comment |
|
Comment 1 by pkotw...@chromium.org
, Nov 28