New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 909706 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome Extensions API method chrome.topSites.get returns strange results

Reported by stepanya...@gmail.com, Nov 28

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.55 YaBrowser/19.1.1.25 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. Manually add/remove some sites on the new tab page
2. Install extension that has topSites permission
3. Try to call chrome.topSites.get in extensions background page

What is the expected behavior?
I expect chrome.topSites.get to return the list of sites from new tab page

What went wrong?
It returns strange result, not the list of sites from new tab page. It seems some sites from history, but i'm not sure

Did this work before? Yes 71.0.3578.62

Does this work in other browsers? Yes

Chrome version: 72.0.3624.0  Channel: canary
OS Version: OS X 10.14.0
Flash Version: 

Doesn't reproduced on 70.0.3538.110 and 71.0.3578.62
 
The User-Agent of Chrome: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3624.0 Safari/537.36
Components: Platform>Extensions
Labels: Needs-Bisect Needs-Triage-M72
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Needs-Feedback
Thanks for filing the issue...

Tried to reproduce the issue on reported chrome 72.0.3624.0 and 71.0.3578.62 using Mac 10.14.0. Attaching screencast for reference.
Steps:
-----
1. Launched reported chrome
2. Installed extension as per attached screenshot 
3. Enabled Developer mode and opened background page >> console >> Entered text chrome.topSites.get
As we have observed that the functions on the console page (observed same behaviour on chrome 72.0.3624.0 and 71.0.3578.62)  

Reporter: Could you please check the attached screen cast and let us know if anything missed from our end and If possible provide a sample extension and screencast so that we can investigate the issue further.

Thanks..!

909706.mp4
1.2 MB View Download
I have investigated that problem starts to reproduce after the site deletion from NTP.
Before the deletion everything is ok, take a look at screencast 1.mp4
But after deletion nothing is deleted or added to chrome.topSites (screencast 2.mp4)


2.mp4
16.8 MB Download
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 29

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Interop
Labels: -Pri-2 -Needs-Bisect RegressedIn-70 Target-71 Target-72 M-71 FoundIn-71 FoundIn-70 FoundIn-72 hasbisect Pri-1
Owner: kristip...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on the reported chrome 72.0.3624.0 and issue not seen on latest canary 72.0.3625.0 using Mac 10.14.0. As we are getting all good builds. Hence, providing the manual bisect information from https://omahaproxy.appspot.com/. Inconsistent behavior seen on Windows and Ubuntu.

Bisect Info:
================
Good build: 70.0.3503.0
Bad build:  70.0.3504.0

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/70.0.3503.0..70.0.3504.0?pretty=fuller&n=10000

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1149458/

Kristi Park:Please confirm the issue and help in re-assigning if it is not related to your change. Adding RBS label for M-71 feel free to change it if not required.

Thanks!
Cc: ramyan@chromium.org
Status: WontFix (was: Assigned)
This is working as intended. chrome.topSites.get returns the list of most visited sites based on history, and this is what is shown on the NTP by default. Editing/adding/deleting those shortcuts on the NTP is a separate feature and does not affect this list.

You can confirm this by clicking the gear icon and "Restore default shortcuts". The shortcuts should be what is returned by chrome.topSites.get.

@ramyan, we may need to update the description in https://developer.chrome.com/extensions/topSites#method-get.
Kristi Park, thank you for your response. If it works as intended, I think it will be useful to have API to retrieve the list of shortcuts from NTP
Yes, that's definitely something we're considering. Updates will be posted in bug 911175.

Sign in to add a comment