Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tschumann@google.com 77ef53dc-00d3-4199-afc0-a07378b628c2 Builders failed on: - Mac10.11 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests - Mac10.13 Tests (dbg): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29 - WebKit Mac10.13 (retina): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20%28retina%29
Diff for convenience: crbug.com/909694 [ Mac ] fast/forms/color/color-suggestion-picker-appearance-zoom200.html [ Failure Pass] crbug.com/909694 [ Mac ] fast/forms/select/select-popup-pagekeys.html [ Failure Pass] crbug.com/909694 [ Mac ] fast/forms/textarea/textarea-metrics.html [ Failure Pass] crbug.com/909694 [ Mac ] svg/zoom/page/zoom-zoom-coords.xhtml [ Failure Pass] crbug.com/909694 [ Mac ] virtual/mouseevent_fractional/fast/events/hit-test-clip-path-reference.html [ Failure Pass] crbug.com/909694 [ Mac ] virtual/user-activation-v2/fast/events/hit-test-clip-path-reference.html [ Failure Pass]
it's unclear where those got broken. Assigning to yosin@chromium.org as https://chromium-review.googlesource.com/c/chromium/src/+/1350443 which added a lot of tests is in the range of candidate culprits. Please help finding an owner for this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1fc02a6d452bc9d392162fee7051a088cadf542 commit d1fc02a6d452bc9d392162fee7051a088cadf542 Author: Tim Schumann <tschumann@chromium.org> Date: Wed Nov 28 14:05:32 2018 Mark flaky webkit_layout_tests on Mac. TBR=yosin@chromium.org Bug: 909694 Change-Id: Ie6fd36ef024ce524152d5b718fbbc848b1735f05 Reviewed-on: https://chromium-review.googlesource.com/c/1353958 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611680} [modify] https://crrev.com/d1fc02a6d452bc9d392162fee7051a088cadf542/third_party/blink/web_tests/TestExpectations
Thanks tschumann@ for marking these tests! These failures are cause by my patch which changes Element#innerText == testRunner.dumpAsText(). I'll rebase test expectations for them.
Committing... http://crrev.com/c/1354742
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7952656cf5cf3f36826c179d4901c95822f5da48 commit 7952656cf5cf3f36826c179d4901c95822f5da48 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Thu Nov 29 05:12:30 2018 Update web test expectation for Mac bot failures after Element#innerText updates. This updates web test expectation for following files for Mac bots: - fast/forms/color/color-suggestion-picker-appearance-zoom200.html - fast/forms/select/select-popup-pagekeys.html - fast/forms/textarea/textarea-metrics.html - svg/zoom/page/zoom-zoom-coords.xhtml - virtual/mouseevent_fractional/fast/events/hit-test-clip-path-reference.html - virtual/user-activation-v2/fast/events/hit-test-clip-path-reference.html This patch is a follow-up the CL[1] which missed to update this expectation. [1] http://crrev.com/c/1350443 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText TBR=tschumann@google.com Bug: 909694 Change-Id: Id77b295033998c31243301cc93930613136b35c8 Reviewed-on: https://chromium-review.googlesource.com/c/1354742 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612046} [modify] https://crrev.com/7952656cf5cf3f36826c179d4901c95822f5da48/third_party/blink/web_tests/TestExpectations [delete] https://crrev.com/682293b78f635638812908f3d8ef1881dfc891a7/third_party/blink/web_tests/fast/events/hit-test-clip-path-reference-expected.txt [modify] https://crrev.com/7952656cf5cf3f36826c179d4901c95822f5da48/third_party/blink/web_tests/fast/forms/color/color-suggestion-picker-appearance-zoom200-expected.txt [modify] https://crrev.com/7952656cf5cf3f36826c179d4901c95822f5da48/third_party/blink/web_tests/fast/forms/select/select-popup-pagekeys-expected.txt [modify] https://crrev.com/7952656cf5cf3f36826c179d4901c95822f5da48/third_party/blink/web_tests/fast/forms/textarea/textarea-metrics-expected.txt [modify] https://crrev.com/7952656cf5cf3f36826c179d4901c95822f5da48/third_party/blink/web_tests/svg/zoom/page/zoom-zoom-coords-expected.txt [delete] https://crrev.com/682293b78f635638812908f3d8ef1881dfc891a7/third_party/blink/web_tests/virtual/mouseevent_fractional/fast/events/hit-test-clip-path-reference-expected.txt [delete] https://crrev.com/682293b78f635638812908f3d8ef1881dfc891a7/third_party/blink/web_tests/virtual/user-activation-v2/fast/events/hit-test-clip-path-reference-expected.txt
Let's see Mac bots will be green.
Mark Verified, The patch is picked up in following builds: * https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/31210 * https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6884 * https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20%28retina%29/7206
Comment 1 by tschumann@google.com
, Nov 28