Memory leak in //src/net/tools/dump_cache/dump_files.cc
Reported by
daniel.c...@gmail.com,
Nov 28
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0 Steps to reproduce the problem: Read the source What is the expected behavior? not to leak memory What went wrong? A memory leak https://cs.chromium.org/chromium/src/net/tools/dump_cache/dump_files.cc?q=CacheDum&sq=package:chromium&g=0&l=299 should be std::unique_ptr<char[]> buffer(new char[size]) Did this work before? N/A Chrome version: Master Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 31.0 r0
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33368a72d31f331a312a82f48411648682681817 commit 33368a72d31f331a312a82f48411648682681817 Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Nov 28 15:08:30 2018 Fix wrong type on std::unique_ptr Type was a char but should be a char[] BUG= 909692 Change-Id: I2151ab95a0ec0bbefd913f32de1b3e4d51cce6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1354058 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611694} [modify] https://crrev.com/33368a72d31f331a312a82f48411648682681817/net/tools/dump_cache/dump_files.cc
,
Nov 28
Thanks for the report. Fix landed. |
||
►
Sign in to add a comment |
||
Comment 1 by dtapu...@chromium.org
, Nov 28