Issue metadata
Sign in to add a comment
|
Regression: Misplacement is seen in the context menu alignment of apps in App launcher |
||||||||||||||||||||||
Issue descriptionChrome Version:72.0.3218.0/11302.0.0 dev-channel Candy,Celes and Peppy OS:Chrome OS What steps will reproduce the problem? (1)Sign into user >> From chrome://settings/languages, set the chrome OS display language to Arabic (2)Open App launcher,right click to get context menu of any app and observe(Please refer video) Actual: Misplacement is seen in the alignment of context menu of apps in App launcher Expected: No such misplacement should be seen in the alignment of context menu of apps in App launcher when language is Arabic This is a Regression issue as same works fine in M-69 Note: Issue is also seen in M-70 stable
,
Nov 29
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 3
(didn't mean to grab these P-1's)
,
Dec 6
,
Dec 13
,
Dec 13
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e97f255d45a31a0b4d24829507354174e43243b1 commit e97f255d45a31a0b4d24829507354174e43243b1 Author: Alex Newcomer <newcomer@chromium.org> Date: Thu Dec 13 18:27:16 2018 cros: Fix menu anchor bounds in RTL Menu anchor bounds should be mirrored in RTL. Bug: 909672 Change-Id: I3c0895087b08bbfb7baa93787f3ea77411160817 Reviewed-on: https://chromium-review.googlesource.com/c/1368777 Reviewed-by: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#616368} [modify] https://crrev.com/e97f255d45a31a0b4d24829507354174e43243b1/ash/app_list/views/app_list_item_view.cc
,
Dec 14
,
Dec 14
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bd9f98f29c0527fe878824ebdae3996206cd0f4 commit 7bd9f98f29c0527fe878824ebdae3996206cd0f4 Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Dec 14 17:35:55 2018 cros: Fix menu anchor bounds in RTL Menu anchor bounds should be mirrored in RTL. Bug: 909672 Change-Id: I3c0895087b08bbfb7baa93787f3ea77411160817 Reviewed-on: https://chromium-review.googlesource.com/c/1368777 Reviewed-by: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616368}(cherry picked from commit e97f255d45a31a0b4d24829507354174e43243b1) Reviewed-on: https://chromium-review.googlesource.com/c/1377343 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#362} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/7bd9f98f29c0527fe878824ebdae3996206cd0f4/ash/app_list/views/app_list_item_view.cc
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 7bd9f98f29c0527fe878824ebdae3996206cd0f4 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bd9f98f29c0527fe878824ebdae3996206cd0f4 Commit: 7bd9f98f29c0527fe878824ebdae3996206cd0f4 Author: newcomer@chromium.org Commiter: newcomer@chromium.org Date: 2018-12-14 17:35:55 +0000 UTC cros: Fix menu anchor bounds in RTL Menu anchor bounds should be mirrored in RTL. Bug: 909672 Change-Id: I3c0895087b08bbfb7baa93787f3ea77411160817 Reviewed-on: https://chromium-review.googlesource.com/c/1368777 Reviewed-by: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616368}(cherry picked from commit e97f255d45a31a0b4d24829507354174e43243b1) Reviewed-on: https://chromium-review.googlesource.com/c/1377343 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#362} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by newcomer@chromium.org
, Nov 28