Issue metadata
Sign in to add a comment
|
Regression:Content under 'Options' on print preview is seen chopped on changing browser language.
Reported by
pranjali...@etouch.net,
Nov 28
|
||||||||||||||||||||||
Issue descriptionChrome Version:71.0.3578.75 (Official Build) 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}(32/64 bit) OS: Win(7,8,8.1,10) OS What steps will reproduce the problem? 1.Launch chrome ,navigate to 'chrome://settings/appearance' and change font size to large. 2.Change browser language to 'Tamil' and relaunch browser. 3.Now gibe print command and click on 'More setting' on print preview. 4.Observe. Actual : Content under 'Options' on print preview is seen chopped on changing browser language. Expected: Content under 'Options' on print preview should not be seen chopped on changing browser language. This is a regression issue broken in ‘M-71’ and below is the 'Chromium bisect' information: Good Build: 71.0.3551.0 (Revision: 590851) Bad Build : 71.0.3552.2 (Revision: 591210) Using the 'per-revision' script providing the bisect result: You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note:Issue is not seen on ,Mac(10.13.1 , 10.13.6 , 10.14.2) and Linux(14.04 LTS)OS as it does not support browser language translation. Kindly review the attached screen-cast for reference. Thank you.
,
Dec 11
Reproduced in English by setting very large font size and changing the "Headers and footers" string in devtools. Also noticed the change... button had its text broken into 2 lines, instead of expanding horizontally. See screenshots of proposed fixes attached.
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03ff3df7e5497ee093234f29eee018d2c7464a90 commit 03ff3df7e5497ee093234f29eee018d2c7464a90 Author: rbpotter <rbpotter@chromium.org> Date: Tue Dec 11 19:50:29 2018 Print Preview: Fix some large font/language issues Fixing text being cut off in the "Options" section of Print Preview, if words exceed the allocated width. Also fixing "Change..." button text wrapping onto two lines rather than expanding the button horizontally, when text is very large. Bug: 909661 Change-Id: I9e9f62c8a7a23bbdb264f3ce8a1a49d77c75cdcd Reviewed-on: https://chromium-review.googlesource.com/c/1369034 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615630} [modify] https://crrev.com/03ff3df7e5497ee093234f29eee018d2c7464a90/chrome/browser/resources/print_preview/new/destination_settings.html [modify] https://crrev.com/03ff3df7e5497ee093234f29eee018d2c7464a90/chrome/browser/resources/print_preview/new/settings_section.html
,
Dec 12
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbpotter@chromium.org
, Nov 28