New issue
Advanced search Search tips

Issue 909653 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Blue focus ring on 'Learn More' is seen chopped from bottom on changing font size.

Reported by sanyam.g...@etouch.net, Nov 28

Issue description

Chrome Version: 71.0.3578.75 Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}(64 bit)
OS: Mac(10.13.1, 10.13.6, 10.14.2) 

Steps to reproduce:
1. Launch Chrome, navigate to 'chrome://settings/appearance' and change font size to 'Very Small'.
2. Go to 'chrome://settings/reset' and open the reset settings overlay.
3. Press tab to bring focus to 'Learn More' and observe.

Actual Result  : Blue focus ring on 'Learn More' is seen chopped from bottom.
Expected Result: Blue focus ring on 'Learn More' should not be seen chopped from bottom.

This is a regression issue, broken in 'M-69' and below is the per-revision bisect info:
Good Build: 69.0.3447.0(Revision: 563479)
Bad Build : 69.0.3448.0(Revision: 563958)

You are probably looking for a change made after 563540 (known good), but no later than 563541 (first known bad).
CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/51cf2f38c2f2da519af711650c610fbecd9ea14c..681b16bff82f3512c953a2ef044f228bcf2770cb

Suspect: https://chromium.googlesource.com/chromium/src/+/681b16bff82f3512c953a2ef044f228bcf2770cb

@Esmael: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is not reproducible on Windows(7,8,8.1,10) and Linux(14.04) OS

Kindly review the attached screen-cast for reference..

Thank You!

 
Actual Focus.mov
1.8 MB View Download
Expected Focus.mov
1.5 MB View Download
Status: Started (was: Assigned)
Screenshot for https://chromium-review.googlesource.com/c/chromium/src/+/1355527/.
focus.png
57.4 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd5bcad71c5e5606531c306c2c11f8deeffa00b

commit cbd5bcad71c5e5606531c306c2c11f8deeffa00b
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Nov 30 22:58:40 2018

Settings WebUI: reset profile dialog, add padding for link focus ring in body

Bug:  909653 
Change-Id: I3aeb33600e6cf01b2cccfd54d860830b04bff97b
Reviewed-on: https://chromium-review.googlesource.com/c/1355527
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612829}
[modify] https://crrev.com/cbd5bcad71c5e5606531c306c2c11f8deeffa00b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html

Status: Fixed (was: Started)

Sign in to add a comment