Flaky test: GeolocationServiceUnitTest.GeolocationConfig Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30316 Test output log: https://chromium-swarm.appspot.com/task?id=41722f6d5c2aa510 Culprit (87.7% confidence): r611379 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKLAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzMwMzE2L3NlcnZpY2VzX3VuaXR0ZXN0cy9SMlZ2Ykc5allYUnBiMjVUWlhKMmFXTmxWVzVwZEZSbGMzUXVSMlZ2Ykc5allYUnBiMjVEYjI1bWFXYz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20GeolocationServiceUnitTest.GeolocationConfig&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKLAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzMwMzE2L3NlcnZpY2VzX3VuaXR0ZXN0cy9SMlZ2Ykc5allYUnBiMjVUWlhKMmFXTmxWVzVwZEZSbGMzUXVSMlZ2Ykc5allYUnBiMjVEYjI1bWFXYz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4 commit 772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4 Author: Tim Schumann <tschumann@chromium.org> Date: Wed Nov 28 11:20:57 2018 Revert "Move device service to new service APIs" This reverts commit afad685369a526d99fce89d7611fbddb5a27a909. Reason for revert: Findit detected this with 87.7% confidence to be the culprit of GeolocationServiceUnitTest.GeolocationConfig flakiness. Bug: 909637 Original change's description: > Move device service to new service APIs > > Migrates device service code and tests from deprecated service APIs to > new ones. Namely this phases out its use of ServiceContext and > ServiceTest in favor of ServiceBinding and plain old unit tests. > > Bug: 891780 , 906239 > Change-Id: I7677134b5d11e7297b162bbb532dfabb810504d2 > Reviewed-on: https://chromium-review.googlesource.com/c/1345124 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611379} TBR=jam@chromium.org,rockot@google.com,blundell@chromium.org,tsepez@chromium.org Change-Id: I3619eef380d3e46736bf0966359d37e2808d97ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891780 , 906239 Reviewed-on: https://chromium-review.googlesource.com/c/1352766 Reviewed-by: Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611650} [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/chrome/browser/chromeos/login/hid_detection_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/battery_monitor_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/device_sensors/device_sensor_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/generic_sensor/generic_sensor_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/power_monitor_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/vibration_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/extensions/browser/api/serial/serial_apitest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/BUILD.gn [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/BUILD.gn [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/OWNERS [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/device_service.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/device_service.h [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/device_service_test_base.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/device_service_test_base.h [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/public/cpp/hid/fake_input_service_linux.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/public/cpp/hid/fake_input_service_linux.h [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/public/cpp/test/scoped_geolocation_overrider.cc [add] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/unittest_manifest.json [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/service_manager/public/cpp/service_binding.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/service_manager/public/cpp/service_binding.h [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/service_manager/public/cpp/service_context.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/service_manager/public/cpp/service_context.h
Fixed by revert
Comment 1 by bugdroid1@chromium.org
, Nov 28