New issue
Advanced search Search tips

Issue 909620 link

Starred by 1 user
Status: Verified
Owner:
mrobin...@igalia.com
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

ax_dump_tree for Aura/Linux prints spurious output for id attribute

Project Member Reported by mrobin...@igalia.com, Nov 28 
When using ax_dump_tree on Aura/Linux, every node prints an id attribute:

[application] name='Chromium' ATSPI_STATE_ENABLED ATSPI_STATE_SENSITIVE ATSPI_STATE_SHOWING ATSPI_STATE_VISIBLE id=2152
++[frame] name='data:text/html,<input type="text" checked/> - Chromium' ATSPI_STATE_ENABLED ATSPI_STATE_SENSITIVE ATSPI_STATE_SHOWING ATSPI_STATE_VISIBLE id=32723 class:browser/ui/views/frame/BrowserRootView
++++[panel] name='Chromium' ATSPI_STATE_ENABLED ATSPI_STATE_SENSITIVE ATSPI_STATE_SHOWING ATSPI_STATE_VISIBLE id=2152 class:ui/views/window/NonClientView
++++++[title bar] ATSPI_STATE_ENABLED ATSPI_STATE_SENSITIVE ATSPI_STATE_SHOWING ATSPI_STATE_VISIBLE id=32723 class:OpaqueBrowserFrameView
++++++++[push button] name='Minimize' ATSPI_STATE_ENABLED ATSPI_STATE_SENSITIVE id=32723 class:ImageButton
++++++++[push button] name='Maximize' ATSPI_STATE_ENABLED ATSPI_STATE_SENSITIVE id=-1779574277 class:ImageButton

The id attribute should be a string, not an integer. Additionally, we should only print this attribute for elements that actually have it.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b9067165088bd2291bd5a4331af14e35580c12a

commit 7b9067165088bd2291bd5a4331af14e35580c12a
Author: Martin Robinson <mrobinson@igalia.com>
Date: Mon Dec 03 09:23:23 2018

Only print the id in Aura/Linux ax_dump_tree if it exists

Stop printing a bogus integer version of the id attribute for nodes. We
are already printing the string version of this attribute when it is
assigned, so removing this code should just make the output less noisy.

Bug:  909620 
Change-Id: I0b2f08c99ae5e52a14483f27292c5aacd7e5eace
Reviewed-on: https://chromium-review.googlesource.com/c/1352362
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#613029}
[modify] https://crrev.com/7b9067165088bd2291bd5a4331af14e35580c12a/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc

Comment 2 by mrobin...@igalia.com, Dec 3

Status: Verified (was: Assigned)
►

Sign in to add a comment