Example roll: https://chromium-review.googlesource.com/c/chromium/src/+/1352041 Linux layout tests fail with a v8 stack trace: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/242078 The problem was actually detected in V8 once when the suspect CL landed: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/28308 But the bot turned green right after. It should have stayed consistently red, since it also failed consistently on chromium's CQ.
In the subsequent runs the test also fail with the pinned revision, and hence get ignored. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/28309 Maybe there's an infra problem when applying pinned? E.g. the ToT version not properly being reverted? Or pinned not applied at all?
It's very likely, since the compile without patch step has no work to do.
The second bot_update passes the V8 ToT revision as --revision src/v8@revision. It should not pass this argument at all to get the pinned revision.
Hmm, the code looks still good as it is: https://cs.chromium.org/chromium/build/scripts/slave/recipes/blink_downstream.py?q=blink_dow&sq=package:chromium&g=0&l=183 We remove src/v8 from the gclient revisions list to prevent it being set in the second bot_update round. Also the expectations look correct, e.g.: https://chromium.googlesource.com/chromium/tools/build/+/5c8aae01d/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json#705 The second bot_update doesn't pass a revision for src/v8. But in prod, the second bot_update does pass it.
Won't be able to work on this further until mid of next week.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/a4d5837f17aeef08deef02ea60f5cba58985d5eb commit a4d5837f17aeef08deef02ea60f5cba58985d5eb Author: Michael Achenbach <machenbach@chromium.org> Date: Fri Dec 07 13:59:12 2018 [V8] Properly simulate builbucket in blink_downstream recipe Bug: 909615 Change-Id: I2bd0b2fdbaa90f3faceb11af2f8ba520ba833c4c Reviewed-on: https://chromium-review.googlesource.com/c/1367784 Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.py [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/webkit_layout_tests_interrupted.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/webkit_layout_tests_unexpected_error.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/README.recipes.md [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_fail.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json [modify] https://crrev.com/a4d5837f17aeef08deef02ea60f5cba58985d5eb/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/4cc509cfc12a70e3c7964e25389ed8a47ec5c82b commit 4cc509cfc12a70e3c7964e25389ed8a47ec5c82b Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Dec 12 09:11:06 2018 [V8] Fix blink_downstream syncing to pinned revision The bot_update-on-failure step should sync V8 to the pinned revision inside Chromium. This has been achieved by not passing a specific --revision parameter to bot_update. Recently, additional logic in bot_update always passes the project revision to the update call (which here is V8). We now make use of a flag to suppress this behavior. Bug: 909615 Change-Id: Icb2fac3331584ffc785a4b1a28b7b30b154dfea2 Reviewed-on: https://chromium-review.googlesource.com/c/1367785 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> [modify] https://crrev.com/4cc509cfc12a70e3c7964e25389ed8a47ec5c82b/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json [modify] https://crrev.com/4cc509cfc12a70e3c7964e25389ed8a47ec5c82b/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json [modify] https://crrev.com/4cc509cfc12a70e3c7964e25389ed8a47ec5c82b/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json [modify] https://crrev.com/4cc509cfc12a70e3c7964e25389ed8a47ec5c82b/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json [modify] https://crrev.com/4cc509cfc12a70e3c7964e25389ed8a47ec5c82b/scripts/slave/recipes/blink_downstream.py [modify] https://crrev.com/4cc509cfc12a70e3c7964e25389ed8a47ec5c82b/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json [modify] https://crrev.com/4cc509cfc12a70e3c7964e25389ed8a47ec5c82b/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
Comment 1 by machenb...@chromium.org
, Nov 28