New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 909611 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

I have four launcher pages, with the middle two only having one app in each.

Project Member Reported by benwells@chromium.org, Nov 28

Issue description

I'm not sure how I got into this state, but the middle two pages both have PWAs that I have (re)added recently. When adding PWAs it seems to add a page seperator in some cases.
 
Cc: weidongg@chromium.org newcomer@chromium.org
Components: -UI>Shell>Shelf UI>Shell>Launcher
Can you please specify which PWAs?
Is it possible that you have another device with the same account signed in? Different devices have different set of apps, but the position is synced, which might put overflow apps on next page.
Labels: M-72
Owner: weidongg@chromium.org
Cc: wutao@chromium.org xiy...@chromium.org omrilio@chromium.org
One possible cause would be internal app (Discover, Settings and Camera) issue. These 3 apps's positions are not remembered after powerwash (they will use default positions instead of stored positions in backend). But other items' positions are remembered, so the conflicts might occur which push some overflowing items into next page.
My first page is completely full, with the sole item on the second page being the Spotify PWA. The sole item on the third page is the Santa Tracker PWA. I uninstall / install both of these fairly regularly to test / show PWA installation.

The last page starts with Google Photos.

Yes, I do use other devices with the same account. Not super often (maybe once or twice a week).
Partially fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1355178 , remaining issue is that OEM folder position is not synced at the first sign in.
The details of OEM issue: I dragged OEM app outside its folder, then powerwash and login, the OEM app is still in folder, but it is moved outside folder after next login.

I can also drag OEM app into other folder, but it returns back to original position after re-login.

+omrilio@, what is the correct behavior for OEM app? Is it supposed to be dragged outside its folder or even into other folder?
Status: Started (was: Untriaged)
Labels: -Pri-2 Pri-1
We really need to figure this issue soon as the longer it exists, the more users get into a bad state.

Regarding OEM apps, users should be able to drag them out, when they are dragged out it syncs that across devices (this should be the experience today by what I was told 3 years ago, haven't tested).

In other words - as long as an OEM app is in the OEM folder, we do not sync its existence, once it's taken out, we start syncing it. 
Re #9, what happens if OEM app is in non-OEM folder, should we sync the position?
If this is an OEM issue, I can imagine it creating one almost empty page, in this case with just Spotify, if for e.g. something on the first page pushed it out of the first page into the second. But why would there be Santa Tracker in the third page all by itself?
Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.
Labels: -M-73 M-72
(didn't mean to grab these P-1's)
Re #11, My understanding is: there may be two OEM app and Internal app, if they are moved to the first page as a result of incorrect sync one by one, then two apps will overflow one by one which creates two pages.
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b09a200c88ed1f864633961b5b853b1d5293c7e

commit 9b09a200c88ed1f864633961b5b853b1d5293c7e
Author: weidongg@chromium.org <weidongg@chromium.org>
Date: Wed Dec 05 04:54:51 2018

Fix OEM app position issue

Change:
Sync the OEM app position if it is in a folder.

Bug:  909611 
Change-Id: Ibc1a8363b94abb5413a509c298dd21aca4f766d5
Reviewed-on: https://chromium-review.googlesource.com/c/1358005
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613869}
[modify] https://crrev.com/9b09a200c88ed1f864633961b5b853b1d5293c7e/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/9b09a200c88ed1f864633961b5b853b1d5293c7e/chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc

 Issue 905124  has been merged into this issue.
Labels: Merge-Request-72
Owner: newcomer@chromium.org
Mr Weidongg@ is OOO, so taking over for the merge.
Labels: -merge-request-72 Merge-Approved-72
Status: Fixed (was: Started)
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 13

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d504e0ca37c2b64137b61d82bbd368098e569de4

commit d504e0ca37c2b64137b61d82bbd368098e569de4
Author: weidongg@chromium.org <weidongg@chromium.org>
Date: Thu Dec 13 18:08:47 2018

Fix OEM app position issue

Change:
Sync the OEM app position if it is in a folder.

Bug:  909611 
Change-Id: Ibc1a8363b94abb5413a509c298dd21aca4f766d5
Reviewed-on: https://chromium-review.googlesource.com/c/1358005
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613869}(cherry picked from commit 9b09a200c88ed1f864633961b5b853b1d5293c7e)
Reviewed-on: https://chromium-review.googlesource.com/c/1376312
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#329}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/d504e0ca37c2b64137b61d82bbd368098e569de4/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/d504e0ca37c2b64137b61d82bbd368098e569de4/chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc

Labels: CommitLog-Audit-Violation Merge-Without-Approval
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision d504e0ca37c2b64137b61d82bbd368098e569de4 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/d504e0ca37c2b64137b61d82bbd368098e569de4

Commit: d504e0ca37c2b64137b61d82bbd368098e569de4
Author: weidongg@chromium.org
Commiter: newcomer@chromium.org
Date: 2018-12-13 18:08:47 +0000 UTC

Fix OEM app position issue

Change:
Sync the OEM app position if it is in a folder.

Bug:  909611 
Change-Id: Ibc1a8363b94abb5413a509c298dd21aca4f766d5
Reviewed-on: https://chromium-review.googlesource.com/c/1358005
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613869}(cherry picked from commit 9b09a200c88ed1f864633961b5b853b1d5293c7e)
Reviewed-on: https://chromium-review.googlesource.com/c/1376312
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#329}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment