New issue
Advanced search Search tips

Issue 909602 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Launcher-Polish


Sign in to add a comment

Add platform indicator to application

Reported by canopyb...@gmail.com, Nov 28

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 11265.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3611.0 Safari/537.36

Steps to reproduce the problem:
1. Install Spotify from Google Play
2. Install Spotify form Chrome browser ( Add to Home Screen)
3. You can't indicate which one is android or browser

What is the expected behavior?
Show small icon for indicate what platform that application install from.

What went wrong?
When you install same application with difference platform The icon in launcher is same and you will can't indicate which platform of each icon

Did this work before? No 

Chrome version: 72.0.3611.0  Channel: dev
OS Version: 11265.0.0
Flash Version:
 
Screenshot 2018-11-28 at 14.56.02.png
70.3 KB View Download
Components: -UI UI>Shell>Launcher
We should be smarter on how we mark generic apps
Cc: sgabr...@chromium.org shibasheikh@chromium.org newcomer@chromium.org
+UX. Didn't we use to badge the webapp?
Labels: M-73
Owner: sgabr...@chromium.org
Cc: -shibasheikh@chromium.org
Owner: shibasheikh@chromium.org
We used to yes. I am not sure what happened to his or I might not remember the latest decision on app differentiation. @Shiba might however.
Yes, the Chrome app should be badged. 


Cc: -newcomer@chromium.org -sgabr...@chromium.org shibasheikh@chromium.org
Owner: newcomer@chromium.org
assigning to Alex to investigate as this is a regression
Cc: newcomer@chromium.org
Labels: -Pri-2 -M-73 M-72 Pri-1
Owner: ----
Status: Available (was: Unconfirmed)
Thanks shibasheikh@! Launcher team will handle it. Leaving as "available" P-1 for M-72, it should be picked up soon.
Cc: kaznacheev@chromium.org
+kaznacheev, maybe related to some icon changes.
Owner: shibasheikh@chromium.org
I doubt that badging has ever worked for Spotify. The current implementation applies badges only to 1st party apps listed explicitly in the code: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/extensions/gfx_utils.cc?rcl=39e5d59018f0fb802cff93a5d9793c0905b9b497&l=33

I don't think there is a reliable way to tell that a Web app and an Android app are "related". The only solution I can think of is unconditionally badging all Web apps.

Assigning back to Shiba for decision.
Labels: -M-72 M-73
Status: Assigned (was: Available)
Labels: -Pri-1 Pri-2

Sign in to add a comment