New issue
Advanced search Search tips

Issue 909599 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[css-contain] Layout containment suppresses baseline in all elements

Issue description

WPT import https://crrev.com/c/1352970 introduced new failures in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests:

List of new failures:
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-suppress-baseline-002.html [ Failure ]

This import contains upstream changes from e94ae4b34ee6fa3b7d608a011818f34757193725 to dfc543497bd7aabe7f8de18c999f6a0730090757:
Only create an ib-split sequence for truly block-outside children.: https://github.com/web-platform-tests/wpt/commit/dfc543497bd7aabe7f8de18c999f6a0730090757 [affecting this directory]
Test PaymentMethodData data member is converted in constructor (#14205): https://github.com/web-platform-tests/wpt/commit/15d978ae5c4edd49f1ca20f26bc6272e5c319ab6
Tidy layout tests for css-shadow-parts.: https://github.com/web-platform-tests/wpt/commit/f1546bdddd78f87333318d16a0b2cf9b3d1b3986 [affecting this directory]
Quota: Send usage details in return value of estimate().: https://github.com/web-platform-tests/wpt/commit/9c2bea6dac36e36ba1f489d10c2be42160d8f34f
SVG: clamp *-opacity computed value to [0,1]: https://github.com/web-platform-tests/wpt/commit/2bdb49ee3f29c3ae998b19494263147a41ad1eb5 [affecting this directory]
CSS: WPTs for Positioned Layout parsing: https://github.com/web-platform-tests/wpt/commit/09972ca7bd566c05f4451b5dda4678e28850a563 [affecting this directory]
Update Fennec wpt expectations: https://github.com/web-platform-tests/wpt/commit/cfb57dda770db0fb4f5639610ab828e77a9dbce2
CSS: Serialize contain keywords in canonical order: https://github.com/web-platform-tests/wpt/commit/73507a79fcbaa6cae8b0373fd1133546d71a1678 [affecting this directory]
webrtc-wpt: use addTrack(track, stream) to increase firefox compat: https://github.com/web-platform-tests/wpt/commit/641ad0bf0df17b0f422642afa6019a594ef8d0e8
CSS: WPTs for CSS Fragmentation parsing: https://github.com/web-platform-tests/wpt/commit/0c4e091a927fad0091080926e02c8725add704b6 [affecting this directory]
Merge pull request #14184 from ewilligers/defined-selector: https://github.com/web-platform-tests/wpt/commit/b107846c443a49e7743185bb84eb43ab628e22dc
[css-multicol] property parsing, computed values (#14259): https://github.com/web-platform-tests/wpt/commit/fa234f78976ca7abea803fceb3eb53ad3a8603d2 [affecting this directory]
Adding tests for RTCQuicStream.: https://github.com/web-platform-tests/wpt/commit/d68d67d05380a3427ec36de058c26b280351e826
Worker: Add referrer policy tests for shared workers: https://github.com/web-platform-tests/wpt/commit/afed5465220afa36c6f66d79f31c1b4ff770efb7
Sync Mozilla CSS tests as of https://hg.mozilla.org/mozilla-central/rev/ce39a152428a7f8ba5a4c82455dcf501c76c031b . (#14264): https://github.com/web-platform-tests/wpt/commit/f8f28ee94f5bfddcb003d61e331964e57e551ecf [affecting this directory]
Align resource timing buffer full processing to spec PR 168 (reland): https://github.com/web-platform-tests/wpt/commit/cccb52680a601f4de432124092c808e91fad8a15
ReadableStream: modify tests for pipeThrough() having a brand check (#14193): https://github.com/web-platform-tests/wpt/commit/4606e75ca8cd69830223f02e0fbd46fc160f431f
Merge pull request #14258 from emilio/crbug-906369: https://github.com/web-platform-tests/wpt/commit/1ae4033083ad1193afa27f3e689846c46805649d
[css-text] Add a reftest for crbug.com/906369 / webkit.org/b/191807.: https://github.com/web-platform-tests/wpt/commit/5ed4cef548151a3d955dec7fdf219048f3253c76 [affecting this directory]
Update interfaces/scroll-animations.idl (#14251): https://github.com/web-platform-tests/wpt/commit/0febd7959b4a5e68e762a920a8f51f8ef473141e
Update interfaces/reporting.idl (#14250): https://github.com/web-platform-tests/wpt/commit/abae65b52862490e80c8cc6ff563fe735535ee0c
Remove timeout from promise_test (#14253): https://github.com/web-platform-tests/wpt/commit/5df11b94ab1a46595153cd0dd94e4a2409a0a92b [affecting this directory]
Update xhr/abort-during-upload.htm: https://github.com/web-platform-tests/wpt/commit/cb9387b32cc99b0154eddd51bc55a014946edc2f
Remove timeout in async_test for geolocation-API tests: https://github.com/web-platform-tests/wpt/commit/e1683f99f7d17ee272e4eed2e49a3e0933c80276
Remove the timeout in async_test for webrtc and xhr tests: https://github.com/web-platform-tests/wpt/commit/6f0cf0d3b631abdccdefbff113b657dc222ef2c2
Update interfaces/uievents.idl: https://github.com/web-platform-tests/wpt/commit/be0a96f608d92117fe4d666342925da70a8bd6c9
Rewrite `async_test(document.title)` to just `async_test()` (#14232): https://github.com/web-platform-tests/wpt/commit/3573ce8c3157628989bc2657dc4c9646198ba5ea [affecting this directory]
Fetch: Content-Type parsing: https://github.com/web-platform-tests/wpt/commit/62317fb983ca5687e4133d89f5523839fdab7f69
Revert "Inherit the navigation initiator when navigating instead of the parent/opener": https://github.com/web-platform-tests/wpt/commit/681b7a2bad0235ee25ca7b8be843da515348ad2b
Modify the web platform tests with mouse inputs to use TestDriver: https://github.com/web-platform-tests/wpt/commit/54aa4d1e272558eaa65eaaa094c038fa4702331f
Add imageSrcset and imageSizes IDL attributes to HTMLLinkElement: https://github.com/web-platform-tests/wpt/commit/dba9026fee0e7f5294181008a91b18c29030a397
Fix some minor feature policy parsing issues: https://github.com/web-platform-tests/wpt/commit/e6c06e195cb0c9170dbd67c1aec2091fa2c687b4
Inherit the navigation initiator when navigating instead of the parent/opener: https://github.com/web-platform-tests/wpt/commit/75b92bf3d1791dc0e47cd8a716a135e98d2d2937
[css-contain] Fix baseline for elements with contain: layout: https://github.com/web-platform-tests/wpt/commit/3b78c96b77028a81550e43f3561c2c32d23358ab [affecting this directory]
Fix CSSPreloadScanner to avoid missing rules (reland): https://github.com/web-platform-tests/wpt/commit/f54784f108778b4d73d8806774521b30da7b4651
Rename srcset/imgsizes link attributes to imagesrcset/imagesizes: https://github.com/web-platform-tests/wpt/commit/a990dff8729c18279154f66650e83f01911216a4
Signed Exchange: Disallow HEAD request method: https://github.com/web-platform-tests/wpt/commit/4edb777ed3a216e6be6b8a7c13820a25340017dc
Add tests for 'pointer-events: none' on the root element.: https://github.com/web-platform-tests/wpt/commit/58523789a079f6b330c37247e035f76371dd1204
Add CEReactions tests for HTMLButtonElement (#10137): https://github.com/web-platform-tests/wpt/commit/98103d8c3ecbcab364bc0dc86fa176ec673b56d8
fixup! [FileAPI] Remove reference to non-existent file: https://github.com/web-platform-tests/wpt/commit/73167bbb0a01ae0677ef62e2ec40c420ce8f6101
[FileAPI] Remove reference to non-existent file: https://github.com/web-platform-tests/wpt/commit/e4ec373d7c9b04be6bb227ebc0f70ad9b0e49462
Make the ReadableStream subclassing test match the others (#14235): https://github.com/web-platform-tests/wpt/commit/22c24b810505aaf0b63223e093da7dbfec867a81
Add tests that subclassing {Transform,Writable}Stream works (#14228): https://github.com/web-platform-tests/wpt/commit/a994b494fa6f821a7fe390d07a72aa1b41e2d3e0
Add test for "Allow delaying autoplay until video elements become visible (#12732): https://github.com/web-platform-tests/wpt/commit/0570493aa6334949ba3c67b86247ece5bbafbe56
[selectors] :enabled and :disabled CSS selectors (#14200): https://github.com/web-platform-tests/wpt/commit/817ed89af07a457aee927a6b3b3434b49255faf7 [affecting this directory]
[selectors] :defined CSS selector: https://github.com/web-platform-tests/wpt/commit/92a561a3121a1831214a7b9f47931904ae3df5e7 [affecting this directory]

 
Owner: r...@igalia.com
Status: Assigned (was: Untriaged)
Summary: [css-contain] Layout containment suppresses baseline in all elements (was: [WPT] New failures introduced in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests by import https://crrev.com/c/1352970)
First of all, the test is pointing to the wrong reference.
That should be fixed by:
https://bugzilla.mozilla.org/show_bug.cgi?id=1511963
And eventually exported into WPT and re-imported in Chromium.

Apart from that we have some issues yet related to layout containment and baseline.
Since the last update we also noticed a problem with contain: layout. Before everything worked fine, but now our dropdown element is being clipped as if it had contain: paint.
Please tuhoojabotti@ could you provide a reduced example and report a new bug for that particular issue? Tanks.
Yes, I will try to reproduce it in a minimal way. I noticed however that it's not actually clipping, for some reason the element is being covered by other elements below it. I will research it more and try to make a minimal repro.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/784ec6cbbc07fc93b1671f5d2c56b9d84ba7b91c

commit 784ec6cbbc07fc93b1671f5d2c56b9d84ba7b91c
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Mon Dec 17 20:00:11 2018

[css-contain] Layout containment suppress baseline

We were not suppressing baseline in all the cases.
This patch fixes the bug detected by Mozilla test
contain-layout-suppress-baseline-002.html.
At the same time it adds a new test for more elements,
however it's not passing yet due to a different bug crbug.com/671132.

BUG= 909599 
TEST=external/wpt/css/css-contain/contain-layout-baseline-005.html
TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-suppress-baseline-002.html

Change-Id: Id1b984aae1f2a21f655b9c1e42a54115d0a4659c
Reviewed-on: https://chromium-review.googlesource.com/c/1380033
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#617195}
[modify] https://crrev.com/784ec6cbbc07fc93b1671f5d2c56b9d84ba7b91c/third_party/blink/renderer/core/layout/layout_block.cc
[modify] https://crrev.com/784ec6cbbc07fc93b1671f5d2c56b9d84ba7b91c/third_party/blink/renderer/core/layout/layout_table.cc
[modify] https://crrev.com/784ec6cbbc07fc93b1671f5d2c56b9d84ba7b91c/third_party/blink/renderer/core/layout/layout_text_control.cc
[modify] https://crrev.com/784ec6cbbc07fc93b1671f5d2c56b9d84ba7b91c/third_party/blink/web_tests/TestExpectations
[add] https://crrev.com/784ec6cbbc07fc93b1671f5d2c56b9d84ba7b91c/third_party/blink/web_tests/external/wpt/css/css-contain/contain-layout-baseline-005.html
[add] https://crrev.com/784ec6cbbc07fc93b1671f5d2c56b9d84ba7b91c/third_party/blink/web_tests/external/wpt/css/css-contain/reference/contain-layout-baseline-005-ref.html

Status: Fixed (was: Started)

Sign in to add a comment