New issue
Advanced search Search tips

Issue 909592 link

Starred by 3 users
Status: Fixed
Owner:
a...@chromium.org
Closed: Nov 29
Cc:
a...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Chrome crashes when trying to close an NTP.

Reported by avsha...@etouch.net, Nov 28 
Chrome Version : 72.0.3623.0 (Official Build) bc6ec85849f003e7b403d5e48eee959e76de0cd3-refs/branch-heads/3623@{#1} 64 bit
OS : Mac(10.13.6, 10.13.1, 10.14.2)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings page.
2. In "Appearance" section, disable and then agin enable "Show warning before quitting.." toggle button.
3. Open one NTP and close rest of the tabs.
4. Type chrome://restart in omnibox and hit 'ENTER' key. (Warning appears)
5. Try to close the current NTP using 'X' icon and observe.

Actual Result : Chrome crashes when trying to close an NTP using 'X' icon.

Expected Result : After step 5, chrome should not crash and NTP should get closed.

Crash ID:
--------

ID d09fda69f465ef76 (Local Crash ID: 4a18ba63-845b-4b08-a85a-4ad9ead2fb21)

This is a regression issue broken in M-72 and will soon update remaining info.
Good Build : 72.0.3622.0 (Revision : 610747)
Bad Build : 72.0.3623.0 (Revision : 611016)
Actual_Result.mov
7.4 MB View Download
Expected_Result.mov
9.9 MB View Download

Comment 1 by avsha...@etouch.net, Nov 28

Labels: RegressedIn-72 Target-72 FoundIn-72 Stability-Crash HasTestcase hasbisect
Owner: a...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : Chrome crashes when trying to close an NTP. (was: Regression : Chrome crashes when trying to close an NTP using 'X' icon.)
Bisect information:
-------------------

Chromium bisect URL:
https://chromium.googlesource.com/chromium/src/+log/ed098fb72c9407e916bd4ca2b8875b1b675820d3..2788395cc17f551a8619f91df1a4a42079a32ca8

Suspecting : r610853

@Avi : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Able to repro issue in latest Mac Canary #72.0.3624.0
2. Unable to reproduce issue in Linux(14.04 LTS) and Windows(7,8,10) OS.
3. Unable to provide bisect using per-revision script as it shows "We don't have enough builds error message"
4. Tried on other machines but still getting the same error again, hence provided suspect through 'Chromium bisect'

Thank you..!

Comment 2 by robliao@chromium.org, Nov 29

Labels: Hotlist-DesktopUIConsider

Comment 3 by a...@chromium.org, Nov 29

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f19bb479a965dc882d5fd4debf24aaad76878930

commit f19bb479a965dc882d5fd4debf24aaad76878930
Author: Avi Drissman <avi@chromium.org>
Date: Thu Nov 29 19:51:28 2018

Move the quit confirmation dialog earlier.

This avoids it getting triggered by URL requests to quit/restart.

BUG= 909592 , 142944

Change-Id: I353c1334decd556554399349bb207e63fca1352b
Reviewed-on: https://chromium-review.googlesource.com/c/1354399
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612323}
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/app_controller_mac.h
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/browser_process_platform_part_android.cc
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/browser_process_platform_part_android.h
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/browser_process_platform_part_base.cc
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/browser_process_platform_part_base.h
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/browser_process_platform_part_mac.h
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/browser_process_platform_part_mac.mm
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/lifetime/application_lifetime.cc
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/ui/cocoa/confirm_quit_panel_controller.h
[modify] https://crrev.com/f19bb479a965dc882d5fd4debf24aaad76878930/chrome/browser/ui/cocoa/confirm_quit_panel_controller.mm

Comment 5 by a...@chromium.org, Nov 29

Cc: a...@chromium.org
 Issue 910143  has been merged into this issue.

Comment 6 by avsha...@etouch.net, Nov 30

Labels: TE-Verified-M72 TE-Verified-72.0.3626.0
Update :
--------

Verified above issue in latest Canary build #72.0.3626.0 on Mac(10.13.1, 10.13.6, 10.14.2) OS and the issue is fixed. 
Now, able to restart browser using chrome://restart command and Chrome does not crash when trying to close an NTP. Hence adding TE-Verified labels, kindly review an attached screen-cast for reference.

Thank you..!
Canary_results.mov
8.6 MB View Download
►

Sign in to add a comment