New issue
Advanced search Search tips

Issue 909577 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Warn when errorFields don't match request[[options]]

Reported by mcace...@mozilla.com, Nov 28

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0.1 Safari/605.1.15

Steps to reproduce the problem:
Desired spec behavior is defined here:
https://github.com/w3c/payment-request/pull/807

1. Run web platform test payment-request/payment-response/retry-method-warnings-manual.https.html, which is PR at https://github.com/web-platform-tests/wpt/pull/14246

What is the expected behavior?
For the warnings to be shown in the developer console

What went wrong?
The warnings are not being shown. 

Did this work before? No 

Does this work in other browsers? N/A

Chrome version:   Channel: n/a
OS Version: OS X 10.14.1
Flash Version:
 
> Does this work in other browsers?

Plan is to support this across all browsers:
https://github.com/w3c/payment-request/issues/793#issuecomment-426637553

Labels: -Type-Bug -Pri-2 OS-Android OS-Chrome OS-iOS OS-Linux OS-Windows Pri-1 Type-Feature
Owner: rouslan@chromium.org
Status: Assigned (was: Unconfirmed)
Thank you for filing this! :-)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10683bd261b4220a93fe0b735337ef3962b30d07

commit 10683bd261b4220a93fe0b735337ef3962b30d07
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Dec 05 00:57:34 2018

PaymentRequest: Warn when errorFields don't match request[[options]]

Related spec change:
  https://github.com/w3c/payment-request/pull/807

Test:
  https://github.com/web-platform-tests/wpt/pull/14246

Bug:  909577 
Change-Id: Idb4caa2ad08193decaf1d4b0b0435e958176929b
Reviewed-on: https://chromium-review.googlesource.com/c/1359932
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#613788}
[modify] https://crrev.com/10683bd261b4220a93fe0b735337ef3962b30d07/third_party/blink/renderer/modules/payments/payment_request.cc

Status: Fixed (was: Assigned)

Sign in to add a comment