Issue metadata
Sign in to add a comment
|
Factor out CrosFpDevice into separate file |
||||||||||||||||||||||||
Issue descriptionThe CrosFpDevice class is large enough that it mandates being split out into its own file.
,
Dec 1
,
Dec 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca commit b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca Author: Prashant Malani <pmalani@chromium.org> Date: Sat Dec 08 02:14:24 2018 biod: Move CrosFpDevice into its own file The CrosFpDevice code has gotten large enough that it warrants being moved into its own file. This CL does so. It also updates any calls to CrosFpDevice functions to reflect the new file location. BUG= chromium:909562 TEST=Boot with refactored code and check enroll, then reboot, then unlock. Also checkeed that powerwash works. Change-Id: I976f1390d4300d2210f0168fe82a11c66e7aa571 Reviewed-on: https://chromium-review.googlesource.com/1352842 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Prashant Malani <pmalani@chromium.org> Reviewed-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Prashant Malani <pmalani@chromium.org> (cherry picked from commit 556aa2abb876ab03d04b9bbac11d0ad07515dab0) (cherry picked from commit 2d7d47b3de07d12ceb3ff1939db3ef47bdce1d18) Reviewed-on: https://chromium-review.googlesource.com/c/1362371 Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/cros_fp_biometrics_manager.h [add] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/cros_fp_device.cc [modify] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/BUILD.gn [add] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/cros_fp_device.h [modify] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/cros_fp_biometrics_manager.cc [modify] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/tools/bio_crypto_init.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 29