New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 909562 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Proj-Fingerprints



Sign in to add a comment

Factor out CrosFpDevice into separate file

Project Member Reported by pmalani@chromium.org, Nov 28

Issue description

The CrosFpDevice class is large enough that it mandates being split out into its own file.




 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/556aa2abb876ab03d04b9bbac11d0ad07515dab0

commit 556aa2abb876ab03d04b9bbac11d0ad07515dab0
Author: Prashant Malani <pmalani@chromium.org>
Date: Thu Nov 29 20:11:10 2018

biod: Move CrosFpDevice into its own file

The CrosFpDevice code has gotten large enough that it warrants
being moved into its own file. This CL does so. It also updates any
calls to CrosFpDevice functions to reflect the new file location.

BUG= chromium:909562 
TEST=Boot with refactored code and check enroll, then reboot, then
     unlock. Also checkeed that powerwash works.

Change-Id: I976f1390d4300d2210f0168fe82a11c66e7aa571
Reviewed-on: https://chromium-review.googlesource.com/1352842
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>

[modify] https://crrev.com/556aa2abb876ab03d04b9bbac11d0ad07515dab0/biod/cros_fp_biometrics_manager.h
[add] https://crrev.com/556aa2abb876ab03d04b9bbac11d0ad07515dab0/biod/cros_fp_device.cc
[modify] https://crrev.com/556aa2abb876ab03d04b9bbac11d0ad07515dab0/biod/BUILD.gn
[add] https://crrev.com/556aa2abb876ab03d04b9bbac11d0ad07515dab0/biod/cros_fp_device.h
[modify] https://crrev.com/556aa2abb876ab03d04b9bbac11d0ad07515dab0/biod/cros_fp_biometrics_manager.cc
[modify] https://crrev.com/556aa2abb876ab03d04b9bbac11d0ad07515dab0/biod/tools/bio_crypto_init.cc

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 8

Labels: merge-merged-factory-nami-10715.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca

commit b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca
Author: Prashant Malani <pmalani@chromium.org>
Date: Sat Dec 08 02:14:24 2018

biod: Move CrosFpDevice into its own file

The CrosFpDevice code has gotten large enough that it warrants
being moved into its own file. This CL does so. It also updates any
calls to CrosFpDevice functions to reflect the new file location.

BUG= chromium:909562 
TEST=Boot with refactored code and check enroll, then reboot, then
     unlock. Also checkeed that powerwash works.

Change-Id: I976f1390d4300d2210f0168fe82a11c66e7aa571
Reviewed-on: https://chromium-review.googlesource.com/1352842
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
(cherry picked from commit 556aa2abb876ab03d04b9bbac11d0ad07515dab0)
(cherry picked from commit 2d7d47b3de07d12ceb3ff1939db3ef47bdce1d18)
Reviewed-on: https://chromium-review.googlesource.com/c/1362371
Reviewed-by: YH Lin <yueherngl@chromium.org>
Commit-Queue: YH Lin <yueherngl@chromium.org>
Tested-by: YH Lin <yueherngl@chromium.org>

[modify] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/cros_fp_biometrics_manager.h
[add] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/cros_fp_device.cc
[modify] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/BUILD.gn
[add] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/cros_fp_device.h
[modify] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/cros_fp_biometrics_manager.cc
[modify] https://crrev.com/b97d2e3c3ca0097b674e4b12a9cfa87253bfd9ca/biod/tools/bio_crypto_init.cc

Sign in to add a comment