Issue metadata
Sign in to add a comment
|
content_unittests failing on multiple builders |
||||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of shend@chromium.org content_unittests failing on multiple builders Builders failed on: - Win10 Tests x64 (dbg): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29 - Win7 Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29
,
Nov 28
I can't figure out what CL broke this...so I'm just going to add a base::test::ScopedTaskEnvironment member to the fixture as mentioned in the error.
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49e5b6b1cee90c8f2f56210505cb44b7a87c516e commit 49e5b6b1cee90c8f2f56210505cb44b7a87c516e Author: Darren Shen <shend@chromium.org> Date: Wed Nov 28 02:24:02 2018 [sheriff] Add scoped task environment to failing a11y tests. The error message is saying to add a scoped task environment. TBR=nektar@chromium.org Bug: crbug.com/909062 Change-Id: I5aca973574fd8754bdfc1ef44af1319a494b3d13 Reviewed-on: https://chromium-review.googlesource.com/c/1352869 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#611521} [modify] https://crrev.com/49e5b6b1cee90c8f2f56210505cb44b7a87c516e/content/browser/accessibility/browser_accessibility_unittest.cc
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cda84dd8f8744f8a47831d13e20ae665706add28 commit cda84dd8f8744f8a47831d13e20ae665706add28 Author: Tim Schumann <tschumann@chromium.org> Date: Wed Nov 28 12:23:23 2018 Attempt to fix the flaky BrowserAccessiblityTests for windows. Examples: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73206 A similar treatment fixed a problem when interacting with the BrowserAccessibilityComWin object for content/browser/accessibility/browser_accessibility_unittest.cc browser_accessibility_win_unittest.cc is facing problems with accessing invalid memory and also interacting with BrowserAccessibilityComWin -- there's a chance these problems are related. Error message: Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: RtlInitUnicodeString [0x77DEE41B+499] RtlFreeHeap [0x77DEE023+126] free_base [0x737CDCF7+39] calloc_base [0x737CAF0B+2875] free_dbg [0x737CD6DC+124] free [0x737CDCA0+32] uprv_free_63 [0x731F1900+80] icu_63::UnicodeSet::releasePattern [0x732C2067+39] icu_63::UnicodeSet::~UnicodeSet [0x732C2026+230] icu_63::UnicodeSet::`scalar deleting destructor' [0x732C11B5+37] std::default_delete<icu_63::UnicodeSet>::operator() [0x725F76C4+52] std::unique_ptr<icu_63::UnicodeSet,std::default_delete<icu_63::UnicodeSet> >::~unique_ptr<icu_63::UnicodeSet,std::default_delete<icu_63::UnicodeSet> > [0x725F763D+61] base::subtle::NoBarrier_Load [0x725F75EB+59] base::subtle::Acquire_Load [0x725F7593+67] base::i18n::NormalizeFileNameEncoding [0x725F7512+818] base::internal::FunctorTraits<void (__cdecl*)(void *),void>::Invoke<void (__cdecl*const &)(void *),void * const &> [0x71605AD7+55] base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl*const &)(void *),void * const &> [0x71605A0A+58] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void *),void *>,void __cdecl(void)>::RunImpl<void (__cdecl*const &)(void *),std::tuple<void *> const &,0> [0x716059CA+74] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void *),void *>,void __cdecl(void)>::Run [0x7160587F+63] base::RepeatingCallback<void __cdecl(void)>::Run [0x71601F51+49] base::AtExitManager::ProcessCallbacksNow [0x71601951+337] base::AtExitManager::~AtExitManager [0x716012AB+363] std::default_delete<base::AtExitManager>::operator() [0x050F1AA7+39] std::unique_ptr<base::AtExitManager,std::default_delete<base::AtExitManager> >::~unique_ptr<base::AtExitManager,std::default_delete<base::AtExitManager> > [0x050EF57D+61] base::TestSuite::~TestSuite [0x050EF0AB+91] content::ContentTestSuiteBase::~ContentTestSuiteBase [0x050E339F+15] content::ContentTestSuite::~ContentTestSuite [0x050E337E+46] content::ContentTestSuite::`scalar deleting destructor' [0x050E3535+37] std::default_delete<base::TestSuite>::operator() [0x050E3F14+52] std::unique_ptr<base::TestSuite,std::default_delete<base::TestSuite> >::~unique_ptr<base::TestSuite,std::default_delete<base::TestSuite> > [0x050E3C6D+61] content::UnitTestTestSuite::~UnitTestTestSuite [0x050E3B63+115] main [0x050E2B0D+269] invoke_main [0x0510A6DE+30] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:78) __scrt_common_main_seh [0x0510A841+337] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) __scrt_common_main [0x0510A90D+13] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326) mainCRTStartup [0x0510A918+8] (f:\dd\vctools\crt\vcstartup\src\startup\exe_main.cpp:17) BaseThreadInitThunk [0x7783337A+18] RtlInitializeExceptionChain [0x77DF92B2+99] RtlInitializeExceptionChain [0x77DF9285+54] TBR=nektar@chromium.org Bug: 909062 Change-Id: Ic5cb5fc26aed105dfebbffa05be06f822d7d14df Reviewed-on: https://chromium-review.googlesource.com/c/1352130 Reviewed-by: Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611667} [modify] https://crrev.com/cda84dd8f8744f8a47831d13e20ae665706add28/content/browser/accessibility/browser_accessibility_win_unittest.cc
,
Nov 28
,
Nov 28
Indeed, builds are green again :) Marking this one as fixed. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by shend@chromium.org
, Nov 28