New issue
Advanced search Search tips

Issue 909056 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Use async functions for files app tests

Project Member Reported by sa...@chromium.org, Nov 28

Issue description

Async-await is now allowed. Tests using async-await are more readable than promise tests or steps runner tests. Add support for writing tests using async-await and maybe convert the existing tests.
 
Cc: joelhockey@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1c7c3baada6b9ba01ff419ef3ad3088ed3c7306

commit b1c7c3baada6b9ba01ff419ef3ad3088ed3c7306
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 05:50:01 2018

Support writing files app integration tests directly as async functions.

Convert keyboardSelectDriveDirectoryTree as an example.

Bug:  909056 
Change-Id: Ie08b6a787f4d9397d832f435b8f650d647e61ceb
Reviewed-on: https://chromium-review.googlesource.com/c/1349157
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612062}
[add] https://crrev.com/b1c7c3baada6b9ba01ff419ef3ad3088ed3c7306/ui/file_manager/integration_tests/.eslintrc.js
[modify] https://crrev.com/b1c7c3baada6b9ba01ff419ef3ad3088ed3c7306/ui/file_manager/integration_tests/file_manager/background.js
[modify] https://crrev.com/b1c7c3baada6b9ba01ff419ef3ad3088ed3c7306/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
[modify] https://crrev.com/b1c7c3baada6b9ba01ff419ef3ad3088ed3c7306/ui/file_manager/integration_tests/test_util.js

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80223a4b35f924d18a9bbd32435ece5fd49df23d

commit 80223a4b35f924d18a9bbd32435ece5fd49df23d
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 07:22:11 2018

Convert file_display.js to use async-await.

Bug:  909056 
Change-Id: Ic5a91cccb89c55d65217e6e55444878e4ab623cd
Reviewed-on: https://chromium-review.googlesource.com/c/1354733
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612085}
[modify] https://crrev.com/80223a4b35f924d18a9bbd32435ece5fd49df23d/ui/file_manager/integration_tests/file_manager/file_display.js

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaf6bdfe6631c6128bf737b51eadf2850407d453

commit eaf6bdfe6631c6128bf737b51eadf2850407d453
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 07:24:15 2018

Convert sort_columns.js to use async-await.

Bug:  909056 
Change-Id: Idafd58064585c900805629044cd192b2cfe2461a
Reviewed-on: https://chromium-review.googlesource.com/c/1354731
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612086}
[modify] https://crrev.com/eaf6bdfe6631c6128bf737b51eadf2850407d453/ui/file_manager/integration_tests/file_manager/sort_columns.js

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b1eb5a02b3881615fe8e89f6bf5bba5284d4b91

commit 5b1eb5a02b3881615fe8e89f6bf5bba5284d4b91
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 07:32:01 2018

Convert copy_between_windows.js to use async-await.

Bug:  909056 
Change-Id: Ifd26dc5037d52bf98973b9e500695cbc27ecc6f8
Reviewed-on: https://chromium-review.googlesource.com/c/1354735
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612088}
[modify] https://crrev.com/5b1eb5a02b3881615fe8e89f6bf5bba5284d4b91/ui/file_manager/integration_tests/file_manager/copy_between_windows.js

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e543b539b5cffcb3a91b388a72ee21657acf46b

commit 9e543b539b5cffcb3a91b388a72ee21657acf46b
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 07:32:20 2018

Convert zip_files.js to use async-await.

Bug:  909056 
Change-Id: I59ba6c3b5bbaa22551a3b31229f394ce24ed0470
Reviewed-on: https://chromium-review.googlesource.com/c/1354750
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612089}
[modify] https://crrev.com/9e543b539b5cffcb3a91b388a72ee21657acf46b/ui/file_manager/integration_tests/file_manager/zip_files.js

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d91e908b0304fa42e952d426a75fefb119b6a6b

commit 1d91e908b0304fa42e952d426a75fefb119b6a6b
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 08:29:14 2018

Convert open_audio_files.js to use async-await.

Bug:  909056 
Change-Id: Iaf5d3909b8a63f4beca7feda97e20695e5537a2b
Reviewed-on: https://chromium-review.googlesource.com/c/1354747
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612099}
[modify] https://crrev.com/1d91e908b0304fa42e952d426a75fefb119b6a6b/ui/file_manager/integration_tests/file_manager/open_audio_files.js

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66b6f12b23eeb2de84335d3e1abf06dbdc5cc6fc

commit 66b6f12b23eeb2de84335d3e1abf06dbdc5cc6fc
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 08:38:05 2018

Convert my_files.js to use async-await.

Bug:  909056 
Change-Id: Ifd3eeffdc9bca6befdb21c7db84514717516cd21
Reviewed-on: https://chromium-review.googlesource.com/c/1354744
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612105}
[modify] https://crrev.com/66b6f12b23eeb2de84335d3e1abf06dbdc5cc6fc/ui/file_manager/integration_tests/file_manager/my_files.js

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57da0c4f2fdb289b42f7861cbf31cbbf0432808f

commit 57da0c4f2fdb289b42f7861cbf31cbbf0432808f
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 09:07:18 2018

Convert suggest_app_dialog.js to use async-await.

Bug:  909056 
Change-Id: I526a3f743c2c458caad3f3dbaf899d9ef6e64518
Reviewed-on: https://chromium-review.googlesource.com/c/1354748
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612110}
[modify] https://crrev.com/57da0c4f2fdb289b42f7861cbf31cbbf0432808f/ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28b38915523443c4308403cffd24fa05589c1e66

commit 28b38915523443c4308403cffd24fa05589c1e66
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 09:16:20 2018

Convert transfer.js to use async-await.

Bug:  909056 
Change-Id: I6ed0a7d0d48b3b21eaae60ffd5b28d7a1c134024
Reviewed-on: https://chromium-review.googlesource.com/c/1354732
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612113}
[modify] https://crrev.com/28b38915523443c4308403cffd24fa05589c1e66/ui/file_manager/integration_tests/file_manager/transfer.js

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93568e3a9799360e3e7b6df5fdbad9bdcb00bf0d

commit 93568e3a9799360e3e7b6df5fdbad9bdcb00bf0d
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 10:55:08 2018

Convert quick_view.js to use async-await.

Bug:  909056 
Change-Id: I0ed854a15d1ba9a2bfdda3be71430a34b808bfc8
Reviewed-on: https://chromium-review.googlesource.com/c/1351978
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612139}
[modify] https://crrev.com/93568e3a9799360e3e7b6df5fdbad9bdcb00bf0d/ui/file_manager/integration_tests/file_manager/quick_view.js

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c155df8027d7f3ed00c8bbcce9b78bf9583d52b

commit 0c155df8027d7f3ed00c8bbcce9b78bf9583d52b
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 11:12:05 2018

Convert some more smaller files app tests to use async-await.

Convert:
- open_image_files.js
- restore_geometry.js
- restore_prefs.js

Bug:  909056 
Change-Id: Idc4c7636b0192878d62aa455ef096a032afed610
Reviewed-on: https://chromium-review.googlesource.com/c/1353067
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612142}
[modify] https://crrev.com/0c155df8027d7f3ed00c8bbcce9b78bf9583d52b/ui/file_manager/integration_tests/file_manager/open_image_files.js
[modify] https://crrev.com/0c155df8027d7f3ed00c8bbcce9b78bf9583d52b/ui/file_manager/integration_tests/file_manager/restore_geometry.js
[modify] https://crrev.com/0c155df8027d7f3ed00c8bbcce9b78bf9583d52b/ui/file_manager/integration_tests/file_manager/restore_prefs.js

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51574954686d71ddedad54669cd0bbd841de6085

commit 51574954686d71ddedad54669cd0bbd841de6085
Author: Sam McNally <sammc@chromium.org>
Date: Thu Nov 29 11:17:40 2018

Convert share_and_manage_dialog.js to use async-await.

Bug:  909056 
Change-Id: I285bf68f024899c169b87129f988b7a5f82c1cd3
Reviewed-on: https://chromium-review.googlesource.com/c/1354749
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612144}
[modify] https://crrev.com/51574954686d71ddedad54669cd0bbd841de6085/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca3b0566e6f52f95573648d2e1a139f06e15c5d

commit eca3b0566e6f52f95573648d2e1a139f06e15c5d
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 00:12:09 2018

Convert recents.js to use async-await.

Bug:  909056 
Change-Id: Ic44a7ba350b852fcdd0a2983125c7239dc8d7a1a
Reviewed-on: https://chromium-review.googlesource.com/c/1351328
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612453}
[modify] https://crrev.com/eca3b0566e6f52f95573648d2e1a139f06e15c5d/ui/file_manager/integration_tests/file_manager/recents.js

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/192bd64996127cd34834e09bcb571cd33da8b2b7

commit 192bd64996127cd34834e09bcb571cd33da8b2b7
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 00:13:17 2018

Convert delete.js to use async-await.

Bug:  909056 
Change-Id: I921d0807bf9cf84874664ab89e9a68a60aca4cd5
Reviewed-on: https://chromium-review.googlesource.com/c/1355022
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612455}
[modify] https://crrev.com/192bd64996127cd34834e09bcb571cd33da8b2b7/ui/file_manager/integration_tests/file_manager/delete.js

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64394d906162d630b466f8d1ed7ae8b4f51212cd

commit 64394d906162d630b466f8d1ed7ae8b4f51212cd
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 00:14:18 2018

Convert folder_shortcuts.js to use async-await.

Bug:  909056 
Change-Id: Ib01e78bae85986196f6b2aa03816cdcb2faaa650
Reviewed-on: https://chromium-review.googlesource.com/c/1351974
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612456}
[modify] https://crrev.com/64394d906162d630b466f8d1ed7ae8b4f51212cd/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59ca23a0bd4d4e1bc9b2ec92e92dc19113901369

commit 59ca23a0bd4d4e1bc9b2ec92e92dc19113901369
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 00:22:08 2018

Convert create_new_folder.js to use async-await.

Bug:  909056 
Change-Id: I9b8c0f4a6aaa04d601c50a76311b9a44d2138ff0
Reviewed-on: https://chromium-review.googlesource.com/c/1351985
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612468}
[modify] https://crrev.com/59ca23a0bd4d4e1bc9b2ec92e92dc19113901369/ui/file_manager/integration_tests/file_manager/create_new_folder.js

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/298c4d34447929d34d21c33ab5200151a95f2758

commit 298c4d34447929d34d21c33ab5200151a95f2758
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 01:04:00 2018

Convert grid_view.js to use async-await.

Bug:  909056 
Change-Id: I70453c9a11b2d2cab1fa0355647b333508ba700c
Reviewed-on: https://chromium-review.googlesource.com/c/1351982
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612480}
[modify] https://crrev.com/298c4d34447929d34d21c33ab5200151a95f2758/ui/file_manager/integration_tests/file_manager/grid_view.js

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90bb4ae3e70a5604bcf4ed11e3777f378d35da96

commit 90bb4ae3e70a5604bcf4ed11e3777f378d35da96
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 01:50:37 2018

Convert context_menu.js to use async-await.

Bug:  909056 
Change-Id: I04b2180f58d86db40e8775015f44158916c7a157
Reviewed-on: https://chromium-review.googlesource.com/c/1351981
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612497}
[modify] https://crrev.com/90bb4ae3e70a5604bcf4ed11e3777f378d35da96/ui/file_manager/integration_tests/file_manager/context_menu.js

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a076b615cfa95e48f2b1d951d9f2719b1c420f8d

commit a076b615cfa95e48f2b1d951d9f2719b1c420f8d
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 02:24:33 2018

Convert keyboard_operations.js to use async-await.

Bug:  909056 
Change-Id: I0ee41c828ba5c27c174dc51ade20d7b5fb6f0e80
Reviewed-on: https://chromium-review.googlesource.com/c/1351325
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612524}
[modify] https://crrev.com/a076b615cfa95e48f2b1d951d9f2719b1c420f8d/ui/file_manager/integration_tests/file_manager/keyboard_operations.js

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/745b1ed8f90f295ccbfc464f661091f7edae7f56

commit 745b1ed8f90f295ccbfc464f661091f7edae7f56
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 02:47:44 2018

Convert gear_menu.js to use async-await.

Bug:  909056 
Change-Id: Ic571f2d16d9d906bc176d34f539e53f57b2acbb3
Reviewed-on: https://chromium-review.googlesource.com/c/1355301
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612530}
[modify] https://crrev.com/745b1ed8f90f295ccbfc464f661091f7edae7f56/ui/file_manager/integration_tests/file_manager/gear_menu.js

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bebd3a83308ba1c92b96f6ab5e30ae96374683f

commit 9bebd3a83308ba1c92b96f6ab5e30ae96374683f
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 02:50:09 2018

Convert metadata.js to use async-await.

Bug:  909056 
Change-Id: I0134351962bb3332f90f9430751241f0bf6c2eb5
Reviewed-on: https://chromium-review.googlesource.com/c/1355304
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612532}
[modify] https://crrev.com/9bebd3a83308ba1c92b96f6ab5e30ae96374683f/ui/file_manager/integration_tests/file_manager/metadata.js

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3455c99345e0d34d3b53af89b108c2b27492cb66

commit 3455c99345e0d34d3b53af89b108c2b27492cb66
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 03:04:25 2018

Convert drive_specific.js to use async-await.

Bug:  909056 
Change-Id: If6daa91932bad99510e267ef91cc6808bceeccfa
Reviewed-on: https://chromium-review.googlesource.com/c/1356162
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612537}
[modify] https://crrev.com/3455c99345e0d34d3b53af89b108c2b27492cb66/ui/file_manager/integration_tests/file_manager/drive_specific.js

Project Member

Comment 25 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32f5e3bf642f5660e7e97a9eb766df66040b8c20

commit 32f5e3bf642f5660e7e97a9eb766df66040b8c20
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 03:45:18 2018

Convert providers.js to use async-await.

Bug:  909056 
Change-Id: I6ed186ccb13a6373c8ed0ef559a30892cc89dd1c
Reviewed-on: https://chromium-review.googlesource.com/c/1356169
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612549}
[modify] https://crrev.com/32f5e3bf642f5660e7e97a9eb766df66040b8c20/ui/file_manager/integration_tests/file_manager/providers.js

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96b6c563bdcc79020e960dc33fdccbf164857dc3

commit 96b6c563bdcc79020e960dc33fdccbf164857dc3
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 04:10:09 2018

Convert tab_index.js to use async-await.

Bug:  909056 
Change-Id: I8fbfc11a3076c014cf20d711d82fea36183c0792
Reviewed-on: https://chromium-review.googlesource.com/c/1356171
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612557}
[modify] https://crrev.com/96b6c563bdcc79020e960dc33fdccbf164857dc3/ui/file_manager/integration_tests/file_manager/tab_index.js

Project Member

Comment 27 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb8f68ff7ae4db4e4d518a7cb9f5ab1192991197

commit eb8f68ff7ae4db4e4d518a7cb9f5ab1192991197
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 06:10:58 2018

Convert directory_tree_context_menu.js to use async-await.

Bug:  909056 
Change-Id: If12158a436f4c384c663f7ffcceb081018d6be8d
Reviewed-on: https://chromium-review.googlesource.com/c/1355307
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612582}
[modify] https://crrev.com/eb8f68ff7ae4db4e4d518a7cb9f5ab1192991197/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ce7540f5b068a3c6d21d30726db7c03a68a656f

commit 6ce7540f5b068a3c6d21d30726db7c03a68a656f
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 06:11:09 2018

Convert tasks.js to use async-await.

Bug:  909056 
Change-Id: Ia7eb34e4c6c157f8083d0624d1e5d5066c69135e
Reviewed-on: https://chromium-review.googlesource.com/c/1355312
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612583}
[modify] https://crrev.com/6ce7540f5b068a3c6d21d30726db7c03a68a656f/ui/file_manager/integration_tests/file_manager/tasks.js

Project Member

Comment 29 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9700bfdda8b30b26e37d60d3173b35e3413ab818

commit 9700bfdda8b30b26e37d60d3173b35e3413ab818
Author: Sam McNally <sammc@chromium.org>
Date: Fri Nov 30 06:12:04 2018

Convert file_dialog.js to use async-await.

Bug:  909056 
Change-Id: I57857d8dc027a173e669d8d77bc06c00f42977e4
Reviewed-on: https://chromium-review.googlesource.com/c/1355316
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612584}
[modify] https://crrev.com/9700bfdda8b30b26e37d60d3173b35e3413ab818/ui/file_manager/integration_tests/file_manager/file_dialog.js

Project Member

Comment 30 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12d055c046b12f693c413242f9b6893fa62b8d20

commit 12d055c046b12f693c413242f9b6893fa62b8d20
Author: Sam McNally <sammc@chromium.org>
Date: Mon Dec 03 04:30:43 2018

Remove support for legacy files app integration tests.

- Remove testPromise and StepsRunner.
- Assume all files app integration tests return a promise.
- Change helpers in background.js to use async-await.
- Change setupAndWaitUntilReady to only return the app ID and to not
  take a callback.

Bug:  909056 
Change-Id: I5a2f9c87665ab39b8c814f67332b100dea1e32dc
Reviewed-on: https://chromium-review.googlesource.com/c/1356738
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613000}
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/background.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/context_menu.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/copy_between_windows.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/create_new_folder.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/crostini.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/delete.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/drive_specific.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/file_display.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/gear_menu.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/grid_view.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/install_linux_package_dialog.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/metadata.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/my_files.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/open_audio_files.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/open_image_files.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/open_video_files.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/providers.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/quick_view.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/recents.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/restore_geometry.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/restore_prefs.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/sort_columns.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/tab_index.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/tasks.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/transfer.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/traverse.js
[modify] https://crrev.com/12d055c046b12f693c413242f9b6893fa62b8d20/ui/file_manager/integration_tests/file_manager/zip_files.js

Status: Fixed (was: Assigned)

Sign in to add a comment