New issue
Advanced search Search tips

Issue 909042 link

Starred by 1 user
Status: Started
Owner:
menghuan@chromium.org
Cc:
louiscollard@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix AllocatePCR behavior in trunks_client --init_tpm

Project Member Reported by apronin@google.com, Nov 28 
[Spawned from b/117139584]

When Platform Hierarchy is enabled, trunks_client --init_tpm still fails trying to do AllocatePCR:

Output for `trunks_client --init_tpm`:
[ERROR:tpm_utility_impl.cc(254)] AllocatePCR: Error querying PCRs: TPM_RC_INSUFFICIENT
[ERROR:tpm_utility_impl.cc(232)] InitializeTpm: TPM_RC_INSUFFICIENT

Comment 1 by menghuan@chromium.org, Jan 18 (5 days ago)

Cc: louiscollard@chromium.org
Owner: menghuan@chromium.org
Status: Assigned (was: Untriaged)
The failure comes from https://chromium.googlesource.com/chromiumos/platform2/+/bc9c2774e79db591c705c9374c894f0358236c20/trunks/tpm_generated.cc#3568
  (arraysize(value->pcr_selections) == HASH_COUNT == 3, but response has value->count == 4)

is because the implementation change in cr50. But we don't change the parser in trunks.

The definition in spec is:
#define HASH_COUNT (ALG_SHA1+ALG_SHA256+ALG_SHA384+ALG_SHA512+ALG_SM3_256)

And we support ALG_SHA512 in 
https://chromium-review.googlesource.com/c/chromiumos/third_party/tpm2/+/415108/
but doesn't change the count in tpm_generated.h.

Comment 3 by menghuan@chromium.org, Jan 19 (3 days ago)

Status: Started (was: Assigned)
►

Sign in to add a comment