New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 909026 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Nov 28
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add function to determine when to show the new "show cards from your account" opt-in row in the dropdown.

Project Member Reported by se...@chromium.org, Nov 27 
If should be shown only if:

- The feature is enabled
- The user is not syncing
- The user has server cards
- The user has not already opted-in
- The user is in sync transport mode for Wallet

The last point is checked implicitly by the fact the the user is not syncing and has some cards.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc4e57ff66555a7cbf3ec00e8ae9260d3d09a86c

commit bc4e57ff66555a7cbf3ec00e8ae9260d3d09a86c
Author: sebsg <sebsg@chromium.org>
Date: Wed Nov 28 17:35:42 2018

[AF] Add function to decide when to offer to show cards from account.

It should be shown only if:

- The feature is enabled
- The user is not syncing
- The user has server cards
- The user has not already opted-in
- The user is in sync transport mode for Wallet

The last point is checked implicitly by the fact the the user is not
syncing and has some cards.

Bug:  909026 
Change-Id: Id0976ea98a2be295968f825f1269888b3d820f0d
Reviewed-on: https://chromium-review.googlesource.com/c/1351944
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611755}
[modify] https://crrev.com/bc4e57ff66555a7cbf3ec00e8ae9260d3d09a86c/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/bc4e57ff66555a7cbf3ec00e8ae9260d3d09a86c/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/bc4e57ff66555a7cbf3ec00e8ae9260d3d09a86c/components/autofill/core/browser/personal_data_manager_unittest.cc

Comment 2 by se...@chromium.org, Nov 28

Status: Fixed (was: Started)
►

Sign in to add a comment