[Navi] Show Navi onboarding on startup if NaviOnboarding is on |
|||||||
Issue description
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa40b198cfeb6a4b020cb9c141984fcfa9f70669 commit fa40b198cfeb6a4b020cb9c141984fcfa9f70669 Author: Scott Chen <scottchen@chromium.org> Date: Tue Dec 04 21:18:48 2018 Navi Onboarding: Navi flag forces win10 to show chrome://welcome instead. Originally, win10 users are sent to chrome://welcome-win10 instead of chrome://welcome. When Navi onboarding is enabled, all users should be sent to chrome://welcome to go through the new welcome flow. Bug: 909022 Change-Id: Ib7ef0550e0b8341a9c8753e8f38d00b108a70462 Reviewed-on: https://chromium-review.googlesource.com/c/1355982 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#613697} [modify] https://crrev.com/fa40b198cfeb6a4b020cb9c141984fcfa9f70669/chrome/browser/ui/startup/startup_tab_provider.cc
,
Dec 5
,
Dec 5
Pls add appropriate OSs label.
,
Dec 5
,
Dec 6
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2bd5becb90596431536dba2a7a1b4f312d80e48 commit e2bd5becb90596431536dba2a7a1b4f312d80e48 Author: Scott Chen <scottchen@chromium.org> Date: Thu Dec 06 20:05:17 2018 Navi Onboarding: Navi flag forces win10 to show chrome://welcome instead. Originally, win10 users are sent to chrome://welcome-win10 instead of chrome://welcome. When Navi onboarding is enabled, all users should be sent to chrome://welcome to go through the new welcome flow. Bug: 909022 Change-Id: Ib7ef0550e0b8341a9c8753e8f38d00b108a70462 Reviewed-on: https://chromium-review.googlesource.com/c/1355982 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613697}(cherry picked from commit fa40b198cfeb6a4b020cb9c141984fcfa9f70669) Reviewed-on: https://chromium-review.googlesource.com/c/1366302 Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#123} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/e2bd5becb90596431536dba2a7a1b4f312d80e48/chrome/browser/ui/startup/startup_tab_provider.cc
,
Dec 7
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2bd5becb90596431536dba2a7a1b4f312d80e48 Commit: e2bd5becb90596431536dba2a7a1b4f312d80e48 Author: scottchen@chromium.org Commiter: scottchen@chromium.org Date: 2018-12-06 20:05:17 +0000 UTC Navi Onboarding: Navi flag forces win10 to show chrome://welcome instead. Originally, win10 users are sent to chrome://welcome-win10 instead of chrome://welcome. When Navi onboarding is enabled, all users should be sent to chrome://welcome to go through the new welcome flow. Bug: 909022 Change-Id: Ib7ef0550e0b8341a9c8753e8f38d00b108a70462 Reviewed-on: https://chromium-review.googlesource.com/c/1355982 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613697}(cherry picked from commit fa40b198cfeb6a4b020cb9c141984fcfa9f70669) Reviewed-on: https://chromium-review.googlesource.com/c/1366302 Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#123} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by scottchen@chromium.org
, Nov 29Status: Started (was: Available)