Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rockot@google.com virtual/.../flex-flow-padding.html in webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty ASAN Builders failed on: - WebKit Linux Trusty ASAN: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1703e743503d1194ec730bbc029f45216b2e95d2 commit 1703e743503d1194ec730bbc029f45216b2e95d2 Author: Ken Rockot <rockot@google.com> Date: Tue Nov 27 23:22:26 2018 Revert "[LayoutNG] Support non-horizontal flows in Flexbox" This reverts commit 7fbb7857e15ccc0136737b3081259212596b6f8c. Reason for revert: Persistent failures on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/ - see https://crbug.com/909021 Original change's description: > [LayoutNG] Support non-horizontal flows in Flexbox > > Meaning: column containers, ortho children, and non-horizontal > writing modes > > Bug: 845235 > Change-Id: Iba6525752d0c14a77bc9a13cc75a484cdf3a711d > Reviewed-on: https://chromium-review.googlesource.com/c/1332247 > Commit-Queue: David Grogan <dgrogan@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611268} TBR=cbiesinger@chromium.org,dgrogan@chromium.org Change-Id: Ib66afedb725af13acd85a298c4fd565f02b32019 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845235, 909021 Reviewed-on: https://chromium-review.googlesource.com/c/1352670 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611402} [modify] https://crrev.com/1703e743503d1194ec730bbc029f45216b2e95d2/third_party/blink/renderer/core/layout/flexible_box_algorithm.h [modify] https://crrev.com/1703e743503d1194ec730bbc029f45216b2e95d2/third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc [modify] https://crrev.com/1703e743503d1194ec730bbc029f45216b2e95d2/third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.h [modify] https://crrev.com/1703e743503d1194ec730bbc029f45216b2e95d2/third_party/blink/renderer/core/layout/ng/ng_length_utils.h [modify] https://crrev.com/1703e743503d1194ec730bbc029f45216b2e95d2/third_party/blink/web_tests/TestExpectations
Last build was green, removing from sheriff queue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca commit 17e1310d067d7eb5fb00e04da7c88ab97e1f6eca Author: David Grogan <dgrogan@chromium.org> Date: Tue Dec 11 00:15:48 2018 [LayoutNG] Stop casting LayoutNGFlexibleBox to LayoutFlexibleBox LayoutNGFlexibleBox allowed itself to be casted to a LayoutFlexibleBox but it wasn't one. This caused crashes, naturally. I audited all the calls to IsFlexibleBox* and IsFlexItem*, updating to NG where appropriate. Bug: 845235, 909021 Change-Id: Ibb3ee32a5f7a78b5d46702ad7426597f23e39d2a Reviewed-on: https://chromium-review.googlesource.com/c/1368690 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#615341} [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/css/properties/computed_style_utils.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/dom/first_letter_pseudo_element.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/dom/text.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/editing/visible_units.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/flexible_box_algorithm.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_block.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_block_flow.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_box.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_box.h [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_deprecated_flexible_box.h [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_flexible_box.h [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_media.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/layout_table.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/ng/layout_ng_flexible_box.h [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/ng/ng_layout_input_node.h [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/ng/ng_length_utils.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/table_layout_algorithm_auto.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/renderer/core/layout/text_autosizer.cc [modify] https://crrev.com/17e1310d067d7eb5fb00e04da7c88ab97e1f6eca/third_party/blink/web_tests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7028c4e4bd2d156ed3780a76023d3b77f810fd2 commit c7028c4e4bd2d156ed3780a76023d3b77f810fd2 Author: David Grogan <dgrogan@chromium.org> Date: Tue Dec 11 22:01:41 2018 [LayoutNG] Support non-horizontal flows in Flexbox This includes column containers, ortho children, and non-horizontal writing modes. This is a reland after the original[1] triggered an underlying crash issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1332247 Bug: 845235, 909021 Change-Id: I0d29126d5d4c2f203deecb03ee23480d46b447ef Reviewed-on: https://chromium-review.googlesource.com/c/1371196 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615681} [modify] https://crrev.com/c7028c4e4bd2d156ed3780a76023d3b77f810fd2/third_party/blink/renderer/core/layout/flexible_box_algorithm.h [modify] https://crrev.com/c7028c4e4bd2d156ed3780a76023d3b77f810fd2/third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc [modify] https://crrev.com/c7028c4e4bd2d156ed3780a76023d3b77f810fd2/third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.h [modify] https://crrev.com/c7028c4e4bd2d156ed3780a76023d3b77f810fd2/third_party/blink/renderer/core/layout/ng/ng_length_utils.h [modify] https://crrev.com/c7028c4e4bd2d156ed3780a76023d3b77f810fd2/third_party/blink/web_tests/TestExpectations
Sorry about the bot breakage...
Comment 1 by bugdroid1@chromium.org
, Nov 27