New issue
Advanced search Search tips

Issue 909018 link

Starred by 1 user
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Nov 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

webrunner sometimes crashes when playing video

Project Member Reported by sergeyu@chromium.org, Nov 27 
DCHECK_EQ(state_, STATE_NORMAL) fails in DecoderStream::ReadFromDemuxerStream() when playing video on Fuchsia.
The problem is that FuchsiaVideoDecoder may call DecodeCB(ERROR) synchronously, while DecoderStream doesn't expect it.

Comment 1 by w...@chromium.org, Nov 27

Labels: -Pri-3 M-73 Pri-1
Bumping to P1 for M73, since this seems straightforward to fix, and kind of important for media playback ;)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49acd6a57f295efdfbf9cb81b6bbf5b4ee04a765

commit 49acd6a57f295efdfbf9cb81b6bbf5b4ee04a765
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Nov 30 00:17:59 2018

[Fuchsia] Fix FuchsiaVideoDecoder to call DecodeCB asynchronously.

FuchsiaVideoDecoder was calling DecodeCB synchronously in Decode().
DecoderStream doesn't expect this, so it was failing a DCHECK.

Bug:  909018 
Change-Id: Ibf445447b3875ae76ff5d69a5ba9af174836a21b
Reviewed-on: https://chromium-review.googlesource.com/c/1351647
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612461}
[modify] https://crrev.com/49acd6a57f295efdfbf9cb81b6bbf5b4ee04a765/media/filters/fuchsia/fuchsia_video_decoder.cc

Comment 3 by sergeyu@chromium.org, Nov 30

Status: Fixed (was: Started)
►

Sign in to add a comment