New issue
Advanced search Search tips

Issue 909014 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Move download auto-resumptions to native

Project Member Reported by shaktisahu@chromium.org, Nov 27

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eebef5ad57d62b8c52a6c28dfd2d2807093fb45

commit 4eebef5ad57d62b8c52a6c28dfd2d2807093fb45
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Sat Dec 01 18:42:29 2018

Downloads: Determine paused state from download job and in-progress db

Currently to determine whether a download was paused by user, we look at
DownloadJob. This doesn't take into account whether the download has
been restarted. This CL consults with the in-progress DB to
determine this correctly.

Change-Id: I00212fd995f2810ddbb68f97d5b8d1594bc2cd69
Bug: 909014
Reviewed-on: https://chromium-review.googlesource.com/c/1352615
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612940}
[modify] https://crrev.com/4eebef5ad57d62b8c52a6c28dfd2d2807093fb45/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/4eebef5ad57d62b8c52a6c28dfd2d2807093fb45/components/download/internal/common/in_progress_download_manager.cc
[modify] https://crrev.com/4eebef5ad57d62b8c52a6c28dfd2d2807093fb45/components/download/public/common/download_item.h
[modify] https://crrev.com/4eebef5ad57d62b8c52a6c28dfd2d2807093fb45/components/download/public/common/download_item_impl.h
[modify] https://crrev.com/4eebef5ad57d62b8c52a6c28dfd2d2807093fb45/components/download/public/common/mock_download_item_impl.cc
[modify] https://crrev.com/4eebef5ad57d62b8c52a6c28dfd2d2807093fb45/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/4eebef5ad57d62b8c52a6c28dfd2d2807093fb45/content/browser/download/download_manager_impl_unittest.cc

Owner: shaktisahu@chromium.org
Status: Started (was: Unconfirmed)
Components: UI>Browser>Downloads

Sign in to add a comment