Issue metadata
Sign in to add a comment
|
[Orca] window:activate events shouldn't be emitted when page tab switches in already-active window |
||||||||||||||||||||||
Issue descriptionSteps to reproduce: 1. Launch the attached accessible-event listener in a terminal 2. Launch chromium with two different pages loaded 3. Use Alt+1 and Alt+2 several times to switch the active page tab Expected results: window:activate events would not be emitted when the active page tab switches because the active window hasn't changed. Actual results: window:activate events are emitted when the active page tab switches despite the fact that the active window hasn't changed. Impact: Not a big deal because Orca can ignore such spurious events. But it would be nice to not get them in the first place. (Though see note below.) Note: *If* there is a good reason to emit window:activate when the selected page tab switches, *then* it probably would make sense to emit window:deactivate for the tab that stopped being active. The listener is listening for those events as well; but deactivate events are only being emitted when the window is truly being deactivated (e.g. as a result of Alt+Tabbing to another window).
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bf8cb2995fedb53e77ad9be9b1ededfb45b55a0 commit 6bf8cb2995fedb53e77ad9be9b1ededfb45b55a0 Author: Martin Robinson <mrobinson@igalia.com> Date: Tue Jan 08 11:11:52 2019 Don't emit extra AtkWindow::activate events during element focus We were unconditionally emitting these events for explicit focus changes, which isn't something that we want to do. Instead only emit them when the window is actually different. Bug: 909003 Change-Id: I9c6e3c9db4cd6dc5055a4b7b28cc98cc92ae0a5c Reviewed-on: https://chromium-review.googlesource.com/c/1397988 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#620681} [modify] https://crrev.com/6bf8cb2995fedb53e77ad9be9b1ededfb45b55a0/ui/accessibility/platform/ax_platform_node_auralinux.cc [modify] https://crrev.com/6bf8cb2995fedb53e77ad9be9b1ededfb45b55a0/ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc
,
Jan 8
,
Jan 8
I can confirm that the reported problem was solved (thanks!), but the change seems to have introduced a new problem: Before, extra window:activate and state-changed:active events were emitted. Now, extra state-changed:focused events are emitted. This appears to be due to an early return having been removed during the fix.
,
Jan 8
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e00e614ced4cf12b881f2ab933eff703e8f1bb3 commit 4e00e614ced4cf12b881f2ab933eff703e8f1bb3 Author: Martin Robinson <mrobinson@igalia.com> Date: Thu Jan 10 07:48:56 2019 Adjust emission of ATK activate events Instead of sending an activate signal on toplevel windows whenever an item gets focus, send it only when the window itself receives a focus event. Additionally, don't send focus signals for toplevel windows at all. Bug: 909003 Change-Id: I08bc81712da123cd07162a4f5e03d785c929f542 Reviewed-on: https://chromium-review.googlesource.com/c/1402447 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#621495} [modify] https://crrev.com/4e00e614ced4cf12b881f2ab933eff703e8f1bb3/ui/accessibility/platform/ax_platform_node_auralinux.cc [modify] https://crrev.com/4e00e614ced4cf12b881f2ab933eff703e8f1bb3/ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc
,
Jan 10
,
Jan 14
Verifying. No more unexpected events. :) Thanks!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Nov 30