New issue
Advanced search Search tips

Issue 908992 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Nov 28
Cc:
omrilio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

The split divider bar is not properly placed above the snapped windows

Project Member Reported by x...@chromium.org, Nov 27 
Chrome Version: 72.0.3623.0
OS: Chrome

What steps will reproduce the problem?
(1) In tablet mode, open 2 browser windows with more than 1 tab
(2) Enter overview, drag one of the browser windows to snap to left
(3) Drag one tab out of the snapped browser window to the right side of the screen to snap it to right

What is the expected result?
The divider bar should be placed above the snapped windows

What happens instead?
The divider bar is not placed above the snapped windows
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54a1b5205b2da5fe6ed4fbfb01b7b405ea456e37

commit 54a1b5205b2da5fe6ed4fbfb01b7b405ea456e37
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Wed Nov 28 18:49:22 2018

splitscreen: Place the divider bar above the snapped window properly.

When overview and splitview are both active, tab dragging might cause
the misplacement of the divider bar, see the bug description for
details. The reason is that in tab dragging, it's possible the window
gets activated between the drag ends and window snap, this CL makes sure
this case is also properly handled.

Bug:  908992 
Change-Id: I767504153b153f3325dfce9212c647e5f390c0c9
Reviewed-on: https://chromium-review.googlesource.com/c/1352412
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611797}
[modify] https://crrev.com/54a1b5205b2da5fe6ed4fbfb01b7b405ea456e37/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/54a1b5205b2da5fe6ed4fbfb01b7b405ea456e37/ash/wm/splitview/split_view_controller_unittest.cc

Comment 2 by x...@chromium.org, Nov 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment