Overview mode should reserve space for shelf in right / left orientation |
||
Issue descriptionChrome Version: 71.0.3578.49 OS: Chrome OS What steps will reproduce the problem? (1) Use shelf with config: always=show=auto-hide + shelf-position=right (2) Have 2 windows (3) Enter overview mode (F5) What is the expected result? Window tiles are sized without overlapping shelf What happens instead? Shelf is shown when entering overview and the rightmost window tile is overlapping shelf. This could be new with the shelf height / width that has increased in the recent redesign. See attachment.
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f6fd36bb94d977b97ea7b34b8d348672773ed30 commit 1f6fd36bb94d977b97ea7b34b8d348672773ed30 Author: Sammie Quon <sammiequon@google.com> Date: Fri Nov 30 23:59:59 2018 overview: Grid bounds should respect the auto hidden shelf. Adds an inset when the shelf is auto hidden because we want the grid to be centered as if the shelf is fully visible. Test: ash_unittests WindowSelectorTest.GridBounds Bug: 908679 , 908982 Change-Id: Ibccfb0bab70d68a463c3325fa8ca3b7912d0dc65 Reviewed-on: https://chromium-review.googlesource.com/c/1354355 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#612859} [modify] https://crrev.com/1f6fd36bb94d977b97ea7b34b8d348672773ed30/ash/wm/overview/window_selector.cc [modify] https://crrev.com/1f6fd36bb94d977b97ea7b34b8d348672773ed30/ash/wm/overview/window_selector_unittest.cc
,
Dec 3
|
||
►
Sign in to add a comment |
||
Comment 1 by x...@chromium.org
, Nov 27Owner: sammiequon@chromium.org