New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 908970 link

Starred by 1 user
Status: Fixed
Owner:
djean@chromium.org
Closed: Nov 28
Cc:
█ roc...@chromium.org
nedngu...@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

ios_chrome_manual_fill_egtests (iPad Air 2 iOS 11.4) failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 27 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@google.com

ios_chrome_manual_fill_egtests (iPad Air 2 iOS 11.4) failing on multiple builders

Builders failed on: 
- ios-simulator-full-configs: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-full-configs
- ios-slimnav: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav

Comment 1 by nedngu...@google.com, Nov 27

Cc: roc...@chromium.org

Comment 2 by javierrobles@chromium.org, Nov 28 

It is hard to see the logs of the failing tests with those links. The failures around those times on ios-simulator-full-configs are only bot time outs.

Comment 3 by javierrobles@chromium.org, Nov 28

Owner: djean@chromium.org
Found the logs for slim navigation failures:

Exception Name: AssertionFailedException
Exception Reason: ((autofill::features::IsAutofillManualFallbackEnabled()) is true) failed
Exception Details: Manual Fallback phase 2 must be enabled for this Test Case
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/965f2dd775e784aa146f1905cf1013f84a6ab512

commit 965f2dd775e784aa146f1905cf1013f84a6ab512
Author: David Jean <djean@google.com>
Date: Wed Nov 28 14:02:44 2018

Reland "[ios] add credit card test for manual fallback"

This is a reland of 30e1dd180408413c8fce6dbe5b856c048a8ca908

Adding feature flags to slimnav.
Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970

Original change's description:
> [ios] add credit card test for manual fallback
>
> Also adds AutofillManualFallbackPhaseTwo to test bots.
>
> Bug:  845472 
> Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: David Jean <djean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611171}

TBR=rohitrao@chromium.org

Bug:  845472 , 908970 
Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29
Reviewed-on: https://chromium-review.googlesource.com/c/1352328
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611679}
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/build/bots/chromium.mac/ios-slimnav.json
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[add] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller_egtest.mm
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/testing/buildbot/gn_isolate_map.pyl

Comment 5 by djean@chromium.org, Nov 28

Status: Fixed (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452fa50b0defb321f38081c645fad92153e6dd55

commit 452fa50b0defb321f38081c645fad92153e6dd55
Author: Ken Rockot <rockot@google.com>
Date: Wed Nov 28 17:07:50 2018

Revert "Reland "[ios] add credit card test for manual fallback""

This reverts commit 965f2dd775e784aa146f1905cf1013f84a6ab512.

Reason for revert: Still broken, unfortunately:  https://crbug.com/909760 

Original change's description:
> Reland "[ios] add credit card test for manual fallback"
> 
> This is a reland of 30e1dd180408413c8fce6dbe5b856c048a8ca908
> 
> Adding feature flags to slimnav.
> Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970
> 
> Original change's description:
> > [ios] add credit card test for manual fallback
> >
> > Also adds AutofillManualFallbackPhaseTwo to test bots.
> >
> > Bug:  845472 
> > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> > Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> > Commit-Queue: David Jean <djean@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#611171}
> 
> TBR=rohitrao@chromium.org
> 
> Bug:  845472 , 908970 
> Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29
> Reviewed-on: https://chromium-review.googlesource.com/c/1352328
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611679}

TBR=rohitrao@chromium.org,bpastene@chromium.org,javierrobles@chromium.org,djean@chromium.org

Change-Id: Ie4ab90910a6c9b63c0b15044663c2dab68637ae9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  845472 ,  908970 
Reviewed-on: https://chromium-review.googlesource.com/c/1352934
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611741}
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/ios/build/bots/chromium.mac/ios-slimnav.json
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[delete] https://crrev.com/4bd59ad2d83df87dbe7d43dfd7b27fc2529f428e/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller_egtest.mm
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/testing/buildbot/gn_isolate_map.pyl
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453

commit 9e7f3e89661f3f89fb5c41f2cca29cbd02f50453
Author: David Jean <djean@google.com>
Date: Fri Dec 07 12:53:07 2018

Reland "Reland "[ios] add credit card test for manual fallback""

This is a reland of 965f2dd775e784aa146f1905cf1013f84a6ab512

Original change's description:
> Reland "[ios] add credit card test for manual fallback"
> 
> This is a reland of 30e1dd180408413c8fce6dbe5b856c048a8ca908
> 
> Adding feature flags to slimnav.
> Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970
> 
> Original change's description:
> > [ios] add credit card test for manual fallback
> >
> > Also adds AutofillManualFallbackPhaseTwo to test bots.
> >
> > Bug:  845472 
> > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> > Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> > Commit-Queue: David Jean <djean@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#611171}
> 
> TBR=rohitrao@chromium.org
> 
> Bug:  845472 , 908970 
> Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29
> Reviewed-on: https://chromium-review.googlesource.com/c/1352328
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611679}

Bug:  845472 ,  908970 
Change-Id: Ia84d71d73733d5c326443c3441e3127b700e73ef
Reviewed-on: https://chromium-review.googlesource.com/c/1356718
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614677}
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/build/bots/chromium.mac/ios-slimnav.json
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[add] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller_egtest.mm
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/testing/buildbot/gn_isolate_map.pyl
►

Sign in to add a comment