New issue
Advanced search Search tips

Issue 908968 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Shelf icons are blurry for running ARC apps

Project Member Reported by kaznacheev@chromium.org, Nov 27

Issue description

Chrome Version: 72.0.3613.0
OS: ChromeOS

What steps will reproduce the problem?
(0) Set display zoom to a low value (70-80%)
(1) Pin an app to shelf
(2) Shelf icon looks sharp
(3) Launch the app
(4) Observe the icon

What is the expected result?
Icon does not change

What happens instead?
Icon becomes blurry



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Pinned apps.png
18.3 KB View Download
Running apps.png
17.4 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4d0924d91f7cd13c21fed60170fe3f203b5c63

commit da4d0924d91f7cd13c21fed60170fe3f203b5c63
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Fri Nov 30 19:26:37 2018

Increase icon size for ArcAppWindow

The current size (32dp) is too small and results in blurry shelf
icons.

Bug:  908968 
Test: manual
Change-Id: I86303b66ff433995d12389c371dd5cf24eaf6515
Reviewed-on: https://chromium-review.googlesource.com/c/1352770
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612722}
[modify] https://crrev.com/da4d0924d91f7cd13c21fed60170fe3f203b5c63/chrome/browser/ui/ash/launcher/arc_app_window.cc

Comment 3 Deleted

Status: Started (was: Fixed)
Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.
Labels: -M-73 M-72
(didn't mean to grab these P-1's)
Labels: Merge-Request-72
Verified in 73.0.3629.0
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 6

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 10

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66cf3835747c9b1a71852b04eb700bc1d20e59b5

commit 66cf3835747c9b1a71852b04eb700bc1d20e59b5
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Mon Dec 10 19:44:07 2018

Increase icon size for ArcAppWindow

The current size (32dp) is too small and results in blurry shelf
icons.

Bug:  908968 
Test: manual
Change-Id: I86303b66ff433995d12389c371dd5cf24eaf6515
Reviewed-on: https://chromium-review.googlesource.com/c/1352770
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612722}(cherry picked from commit da4d0924d91f7cd13c21fed60170fe3f203b5c63)
Reviewed-on: https://chromium-review.googlesource.com/c/1370399
Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#228}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/66cf3835747c9b1a71852b04eb700bc1d20e59b5/chrome/browser/ui/ash/launcher/arc_app_window.cc

Comment 11 Deleted

Status: Fixed (was: Invalid)
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/66cf3835747c9b1a71852b04eb700bc1d20e59b5

Commit: 66cf3835747c9b1a71852b04eb700bc1d20e59b5
Author: kaznacheev@google.com
Commiter: kaznacheev@chromium.org
Date: 2018-12-10 19:44:07 +0000 UTC

Increase icon size for ArcAppWindow

The current size (32dp) is too small and results in blurry shelf
icons.

Bug:  908968 
Test: manual
Change-Id: I86303b66ff433995d12389c371dd5cf24eaf6515
Reviewed-on: https://chromium-review.googlesource.com/c/1352770
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612722}(cherry picked from commit da4d0924d91f7cd13c21fed60170fe3f203b5c63)
Reviewed-on: https://chromium-review.googlesource.com/c/1370399
Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#228}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment