Make SkRenderer,SkDDL pass media layout tests |
||||
Issue descriptionPatch in https://chromium-review.googlesource.com/c/chromium/src/+/1352440 Ran $ python third_party/blink/tools/run_web_tests.py -t linux_dbg media [1/28] media/controls/paint-controls-webkit-appearance-none.html failed unexpectedly (image diff) [2/28] media/track/track-cue-rendering-vertical.html failed unexpectedly (image diff) [3/28] media/video-aspect-ratio.html failed unexpectedly (image diff) [4/28] media/controls/paint-controls-webkit-appearance-none-custom-bg.html failed unexpectedly (image diff) [5/28] media/track/track-cue-rendering-horizontal.html failed unexpectedly (image diff) [6/28] media/video-canvas-alpha.html failed unexpectedly (image diff) [7/28] media/controls/video-overlay-cast-light-rendering.html failed unexpectedly (image diff) [8/28] media/video-remove-insert-repaints.html failed unexpectedly (image diff) [9/28] media/controls-styling-strict.html failed unexpectedly (image diff) [10/28] media/controls/video-controls-with-cast-rendering.html failed unexpectedly (image diff) [11/28] media/controls/video-overlay-cast-dark-rendering.html failed unexpectedly (image diff) [12/28] media/video-zoom-controls.html failed unexpectedly (image diff) [13/28] media/video-zoom.html failed unexpectedly (image diff) [14/28] media/color-profile-video.html failed unexpectedly (image diff) [15/28] media/controls-without-preload.html failed unexpectedly (image diff) [16/28] media/controls-after-reload.html failed unexpectedly (image diff) [17/28] media/controls-styling.html failed unexpectedly (image diff) [18/28] media/video-controls-rendering.html failed unexpectedly (image diff) [19/28] media/video-layer-crash.html failed unexpectedly (image diff) [20/28] media/video-replaces-poster.html failed unexpectedly (image diff) [21/28] media/color-profile-video-seek-filter.html failed unexpectedly (image diff) [22/28] media/video-no-audio.html failed unexpectedly (image diff) [23/28] media/controls-strict.html failed unexpectedly (image diff) [24/28] media/color-profile-video-seek.html failed unexpectedly (image diff) [25/28] media/video-display-toggle.html failed unexpectedly (image diff) [26/28] media/color-profile-video-seek-object-fit.html failed unexpectedly (image diff) [27/28] media/video-colorspace-yuv422.html failed unexpectedly (content_shell crashed [pid=79611]) [28/28] media/video-colorspace-yuv420.html failed unexpectedly (image diff)
,
Nov 28
,
Dec 11
Recently rerun on ToT, one of the obvious failure was the yuv422 where we don't have a frame. Handing off to Peng right now for investigation into the yuv422 failure: media/video-colorspace-yuv422.html
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b81a46c2c6544bbb70f03c48a3cbd70158a7432b commit b81a46c2c6544bbb70f03c48a3cbd70158a7432b Author: Peng Huang <penghuang@chromium.org> Date: Mon Dec 17 19:32:39 2018 Fix layout test media/video-colorspace-yuv420.html with SkiaRenderer And with this CL, we will not pass internal_format and driver_internal_format around, because we already pass resource_format, and it can be converted to them. Bug: 908957 Change-Id: I1c49c1632376adfae854f306c53b3b8142fb6d2e Reviewed-on: https://chromium-review.googlesource.com/c/1372650 Reviewed-by: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#617185} [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/components/viz/service/display/display_resource_provider.cc [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/components/viz/service/display/display_resource_provider_unittest.cc [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/components/viz/service/display/resource_metadata.h [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/components/viz/service/display/skia_renderer.cc [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/components/viz/service/display_embedder/skia_output_surface_impl.cc [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/gpu/command_buffer/service/shared_image_backing_factory_gl_texture.cc [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/gpu/command_buffer/service/skia_utils.cc [modify] https://crrev.com/b81a46c2c6544bbb70f03c48a3cbd70158a7432b/gpu/command_buffer/service/skia_utils.h
,
Dec 17
The yuv422 no frame problem has been fixed in https://chromium.googlesource.com/chromium/src.git/+/b81a46c2c6544bbb70f03c48a3cbd70158a7432b Assign it back to wei for image diffs. |
||||
►
Sign in to add a comment |
||||
Comment 1 by backer@chromium.org
, Nov 27