New issue
Advanced search Search tips

Issue 908896 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Launcher button is highlighted when the shelf is dragged from the bottom over the launcher button

Project Member Reported by newcomer@chromium.org, Nov 27

Issue description

Chrome Version: 72.0.3623.0

What steps will reproduce the problem?
(1) Autohide the shelf.
(2) Drag a hidden shelf from the bezel, over the launcher button.

What happens instead?
Launcher button highlight shows, but this should not happen.
 
Cc: xiaoh...@chromium.org wutao@chromium.org
Maybe some gesture event is sent to app_list_button even the gesture is not on it?
Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.
Owner: newcomer@chromium.org
Status: Started (was: Available)


Cc: newcomer@chromium.org
Owner: minch@chromium.org
Broken by https://chromium-review.googlesource.com/c/chromium/src/+/1340952

Minch@, please take a look.

When [1] was removed from ShelfLayoutManager, we now send events to the ShelfButton/AppListButton when the shelf is dragged while it is autohidden and not shown.

[1]
    if ((shelf_->GetVisibilityState() == SHELF_AUTO_HIDE &&
         shelf_->GetAutoHideState() == SHELF_AUTO_HIDE_HIDDEN) ||
        shelf_->GetVisibilityState() == SHELF_HIDDEN) {
      // Do not allow children to handle events while the shelf is hidden.
      return true;
    }



The "highlight" here means the ink drop of the app list button when the launcher is open? That should be shown when the launcher is open?
Status: WontFix (was: Started)
Thanks Alex for the explanation offline.

Didn't see this issue in 73.0.3637.0. Marked as won't fix. Please feel free to reopen if you can still see it. 

Sign in to add a comment