New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 908894 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 898693



Sign in to add a comment

Add a Trooper tab to allow turning off code coverage features in Findit

Project Member Reported by liaoyuke@chromium.org, Nov 27

Issue description

Two steps:
1. Refactors the existing AutoRevert tab to Trooper.
2. Add a section for code coverage.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7e11fc2cbf99762baa8c121b6e7ae0da66101695

commit 7e11fc2cbf99762baa8c121b6e7ae0da66101695
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Nov 28 05:21:22 2018

[Findit][code coverage] Add a trooper tab

This CL refactors/adds a trooper tab to the FindIt app to allow anyone
with a google@ account to easily turn off certain features in case of
fire.

Currently, following two features are supported:
1. Auto commit of reverts.
2. Code coverage service.

Bug:  908894 
Change-Id: If140ca40e68a528388dc3ab5541e1c46d46fe47d
Reviewed-on: https://chromium-review.googlesource.com/c/1352590
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19197}
[modify] https://crrev.com/7e11fc2cbf99762baa8c121b6e7ae0da66101695/appengine/findit/dispatch.yaml
[add] https://crrev.com/7e11fc2cbf99762baa8c121b6e7ae0da66101695/appengine/findit/templates/trooper.html
[modify] https://crrev.com/7e11fc2cbf99762baa8c121b6e7ae0da66101695/appengine/findit/ui/elements/findit-app.html
[delete] https://crrev.com/c5aca7f30a1e5557fb7be931d6febde583be8bb7/appengine/findit/handlers/test/change_auto_revert_setting_test.py
[add] https://crrev.com/7e11fc2cbf99762baa8c121b6e7ae0da66101695/appengine/findit/handlers/test/trooper_test.py
[delete] https://crrev.com/c5aca7f30a1e5557fb7be931d6febde583be8bb7/appengine/findit/templates/change_auto_revert_setting.html
[modify] https://crrev.com/7e11fc2cbf99762baa8c121b6e7ae0da66101695/appengine/findit/frontend_main.py
[modify] https://crrev.com/7e11fc2cbf99762baa8c121b6e7ae0da66101695/appengine/findit/module-frontend.yaml
[add] https://crrev.com/7e11fc2cbf99762baa8c121b6e7ae0da66101695/appengine/findit/handlers/trooper.py
[delete] https://crrev.com/c5aca7f30a1e5557fb7be931d6febde583be8bb7/appengine/findit/handlers/change_auto_revert_setting.py

Status: Fixed (was: Started)

Sign in to add a comment