New issue
Advanced search Search tips

Issue 908860 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

tools/perf PRESUBMIT should block people adding non existing benchmarks to the perf shard map

Project Member Reported by nedngu...@google.com, Nov 27

Issue description

In https://chromium-review.googlesource.com/c/chromium/src/+/1351481, I was able to add a non existing benchmark to the shard map and have no problem submitting it. 

tools/perf/PRESUBMIT should prevent this from happening 


We already have a validator script: ./tools/perf/validate_perf_json_config that is run on PRESUBMIT. We can extend this script to error on such case.
 

Sign in to add a comment