Convert use of AccountTrackerService::GetAccountInfo() |
||||||||||||||||||||||||
Issue descriptionIf this is only called for accounts with refresh tokens, then IdentityManager::GetAccountInfoForAccountWithRefreshToken() is a good replacement. Otherwise will need another API. ⛆ |
|
|
,
Nov 28
Given https://bugs.chromium.org/p/chromium/issues/detail?id=908840#c3, we can convert AccountTrackerService::GetAccountInfo() to IdentityManager::GetAccountInfoForAccountWithRefreshToken(). The exceptions are 1. internal uses in components/signin, 2. use from PO2TS delegate implementations.
,
Nov 29
,
Nov 29
,
Jan 11
Available, but no owner or component? Please find a component, as no one will ever find this without one.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
|
|||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||
Comment 1 by sdefresne@chromium.org
, Nov 27There is a pattern that is safe to convert however, this is when iterating over accounts returned by PO2TS, e.g. like done in signed_in_accounts_view_controller.mm. for (const std::string& account_id : oauth2_service->GetAccounts()) { AccountInfo account = accountTracker->GetAccountInfo(account_id); ... } This can be replaced by the following: for (const AccountInfo account_info : identity_service->GetAccountsWithRefreshToken()) { ... }