New issue
Advanced search Search tips

Issue 908858 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment

Convert use of AccountTrackerService::GetAccountInfo()

Project Member Reported by sdefresne@chromium.org, Nov 27

Issue description

If this is only called for accounts with refresh tokens, then IdentityManager::GetAccountInfoForAccountWithRefreshToken() is a good replacement. Otherwise will need another API.
 
There is a pattern that is safe to convert however, this is when iterating over accounts returned by PO2TS, e.g. like done in signed_in_accounts_view_controller.mm.

  for (const std::string& account_id : oauth2_service->GetAccounts()) {
    AccountInfo account = accountTracker->GetAccountInfo(account_id);
    ...
  }

This can be replaced by the following:

  for (const AccountInfo account_info :
      identity_service->GetAccountsWithRefreshToken()) {
    ...
  }
Given https://bugs.chromium.org/p/chromium/issues/detail?id=908840#c3, we can convert AccountTrackerService::GetAccountInfo() to IdentityManager::GetAccountInfoForAccountWithRefreshToken().

The exceptions are 1. internal uses in components/signin, 2. use from PO2TS delegate implementations.
Blockedon: 910196
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Comment 6 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922744

Comment 7 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922749

Comment 8 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922757

Comment 9 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922760

Comment 10 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922765

Comment 11 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922766

Comment 12 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922767

Comment 13 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922771

Comment 14 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922772

Comment 15 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922774

Comment 16 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922775

Comment 17 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922776

Comment 18 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922787

Comment 19 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922789

Comment 20 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922792

Comment 21 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922794

Comment 22 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922795

Comment 23 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922801

Sign in to add a comment