Convert uses of AccountTrackerService::GetAccounts() |
|||||||||||||||||||
Issue descriptionIdentityManager::GetAccountsWithRefreshTokens() returns a sub-set of the accounts returned by AccountTrackerService::GetAccounts(). Looking at uses cases, it is questionable whether this is a valid replacement, or whether a new API is required. It looks like some of the PO2TS delegate clear all accounts with no refresh tokens after loading them (e.g. oauth2_tokem_service_delegate_android.cc). So, need further investigation. ⛆ |
|
|
,
Nov 28
In #2, I meant IdentityManager::GetAccountsWithRefreshTokens().
,
Nov 29
,
Nov 29
,
Nov 29
,
Nov 29
,
Nov 29
,
Nov 29
,
Nov 29
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da0c201140f264cad2706c2435c692cf9cb39e51 commit da0c201140f264cad2706c2435c692cf9cb39e51 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Nov 29 17:04:30 2018 Convert SignedInAccountsViewController to IdentityManager Uses IdentityManager API instead of using the soon to be private ProfileOAuth2TokenService and AccountTrackerService APIs. Bug: 908855 Change-Id: If533b43a698b2f2ea7c24ad43273b4ecba74091f Reviewed-on: https://chromium-review.googlesource.com/c/1354447 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612236} [modify] https://crrev.com/da0c201140f264cad2706c2435c692cf9cb39e51/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/da0c201140f264cad2706c2435c692cf9cb39e51/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm [modify] https://crrev.com/da0c201140f264cad2706c2435c692cf9cb39e51/services/identity/public/objc/identity_manager_observer_bridge.h [modify] https://crrev.com/da0c201140f264cad2706c2435c692cf9cb39e51/services/identity/public/objc/identity_manager_observer_bridge.mm
,
Jan 11
Available, but no owner or component? Please find a component, as no one will ever find this without one.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
|
||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by sdefresne@chromium.org
, Nov 28