New issue
Advanced search Search tips

Issue 908855 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Sign in to add a comment

Convert uses of AccountTrackerService::GetAccounts()

Project Member Reported by sdefresne@chromium.org, Nov 27

Issue description

IdentityManager::GetAccountsWithRefreshTokens() returns a sub-set of the accounts returned by AccountTrackerService::GetAccounts().

Looking at uses cases, it is questionable whether this is a valid replacement, or whether a new API is required. It looks like some of the PO2TS delegate clear all accounts with no refresh tokens after loading them (e.g. oauth2_tokem_service_delegate_android.cc).

So, need further investigation.
 
Given https://bugs.chromium.org/p/chromium/issues/detail?id=908840#c3, we can convert AccountTrackerService::GetAccounts() to IdentityManager::GetAccountsWithValidRefreshTokens().

The exceptions are 1. internal uses in components/signin, 2. use from PO2TS delegate implementations.
In #2, I meant IdentityManager::GetAccountsWithRefreshTokens().
Blockedon: 910146
Blockedon: 910149
Blockedon: 910151
Blockedon: 910152
Blockedon: 910156
Blockedon: 910158
Blockedon: 910160
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da0c201140f264cad2706c2435c692cf9cb39e51

commit da0c201140f264cad2706c2435c692cf9cb39e51
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Nov 29 17:04:30 2018

Convert SignedInAccountsViewController to IdentityManager

Uses IdentityManager API instead of using the soon to be
private ProfileOAuth2TokenService and AccountTrackerService
APIs.

Bug: 908855
Change-Id: If533b43a698b2f2ea7c24ad43273b4ecba74091f
Reviewed-on: https://chromium-review.googlesource.com/c/1354447
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612236}
[modify] https://crrev.com/da0c201140f264cad2706c2435c692cf9cb39e51/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/da0c201140f264cad2706c2435c692cf9cb39e51/ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller.mm
[modify] https://crrev.com/da0c201140f264cad2706c2435c692cf9cb39e51/services/identity/public/objc/identity_manager_observer_bridge.h
[modify] https://crrev.com/da0c201140f264cad2706c2435c692cf9cb39e51/services/identity/public/objc/identity_manager_observer_bridge.mm

Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Comment 12 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922743

Comment 13 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922745

Comment 14 by dxie@google.com, Jan 16 (6 days ago)

Blockedon: 922746

Comment 15 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922769

Comment 16 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922780

Comment 17 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922785

Comment 18 by dxie@google.com, Jan 17 (6 days ago)

Blockedon: 922786

Sign in to add a comment