New issue
Advanced search Search tips

Issue 908851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 1
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 874222



Sign in to add a comment

add cache_storage histograms measuring operation times split by the type of operation

Project Member Reported by wanderview@chromium.org, Nov 27

Issue description

Currently cache_storage tracks operation times and operation queuing times for all operations.  It would be useful to see these broken out by the type of operation (open, match, etc).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218cb607d1cb13d69f0723a7d2a19290296c4598

commit 218cb607d1cb13d69f0723a7d2a19290296c4598
Author: Ben Kelly <wanderview@chromium.org>
Date: Wed Nov 28 22:51:36 2018

CacheStorage: Record operation histograms for each operation type separately.

Currently there are a number of histograms that are recorded for each
"operation" that is scheduled.  All operations are aggregated into a single
bucket.  This makes it hard to tell if one operation type is having a
problem.  Also, some operation types are much more frequent than others which
further skews the metrics.

This CL breaks out these operation histograms by the type of the operation.
The aggregated histograms are still preserved for detecting infrastructure
level changes and comparing to historical data.

This CL also migrates the OperationDuration and QueueDuration to the
LONG_TIMES histogram type.  We have top level metrics that greatly exceed
the default 10 seconds and we expect some of the specific operations will
need to measure very long values on some platforms.

TBR=jkarlin
    cannot be easily further reduced.   Bug 909894  has been filed as a
    follow-on to reduce the code bloat further.

Binary-Size: Increase is due to a large number of new UMA histograms which
Bug:  908851 
Change-Id: Iee607ae8f9f15384058af4977fffcffe027e0dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1352479
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611912}
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/BUILD.gn
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_histogram_utils.h
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_operation.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_operation.h
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_operation_unittest.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_scheduler.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_scheduler.h
[delete] https://crrev.com/70b34093945291add162c9b21c509d6f43a560b3/content/browser/cache_storage/cache_storage_scheduler_client.h
[add] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_scheduler_types.h
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/content/browser/cache_storage/cache_storage_scheduler_unittest.cc
[modify] https://crrev.com/218cb607d1cb13d69f0723a7d2a19290296c4598/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment