New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 908813 link

Starred by 1 user
Status: Fixed
Owner:
█ vabr@chromium.org
hobby only
Closed: Nov 30
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Mark vabr@'s departure from passwords in the code

Project Member Reported by vabr@chromium.org, Nov 27 
vabr@ will no longer be working on Chromium beyond hobby contributions since December 2018. This bug tracks fixing expectations by removing vabr@ from various kinds of ownerships (histograms and code). It also tracks cleaning up TODOs.

Comment 1 by vabr@chromium.org, Nov 27

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6573c92a1748a76391684393b374ee2e3dc58a

commit fc6573c92a1748a76391684393b374ee2e3dc58a
Author: Vaclav Brozek <vabr@chromium.org>
Date: Tue Nov 27 20:36:23 2018

Remove obsolete TODO(vabr) from passwords

There are a few TODO(vabr) in the code. Some of them are about old
code-health improvements which proved to be unimportant enough to
consider, those are being removed in this CL. A few are still relevant
and have an associated bug filed, those are redirected to that bug
instead.

Bug:  908813 ,  397083 , 415449, 543085
Change-Id: If506009ce54016f8a1d9680a90b6516b399af4aa
Reviewed-on: https://chromium-review.googlesource.com/c/1352186
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611292}
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/chrome/browser/password_manager/password_manager_internals_service_unittest.cc
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/components/autofill/core/common/save_password_progress_logger.h
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/components/password_manager/core/browser/sync_credentials_filter.cc
[modify] https://crrev.com/fc6573c92a1748a76391684393b374ee2e3dc58a/components/password_manager/core/browser/sync_credentials_filter.h
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a14ff26047077afea503dbc81e23aef923817e

commit 37a14ff26047077afea503dbc81e23aef923817e
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Nov 28 10:39:25 2018

Remove vabr@ from histograms.xml

This CL replaces <owner> entries for vabr@ with relevant people, to
keep the records up to date after vabr@'s departure.

The CL also removes gcasto@ from all touched histograms. gcasto@ has
not been working on Chromium's password manager for some years now.
Similarly, the CL removes yfriedman@ (because yfriedman@ is more
active on Chromium, vabr@ checked with yfriedman@ that this removal
is OK).

The CL does not add new owners to obsolete histograms.

Bug:  908813 
Change-Id: Ifddb086ab567ec6e7ba2bab39f592715210c9d91
Reviewed-on: https://chromium-review.googlesource.com/c/1352176
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611636}
[modify] https://crrev.com/37a14ff26047077afea503dbc81e23aef923817e/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d005f15952bb6b8fd91c233b90a533f3017185a0

commit d005f15952bb6b8fd91c233b90a533f3017185a0
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Nov 28 12:21:20 2018

Remove obsolete TODO(vabr) from extensions

Cleaning TODO(vabr) in the extensions-related code:
* removing obsolete ones, and
* redirecting others to a bug

Bug:  908813 ,  218451 ,  121325 , 238179
Change-Id: I47fb081201743473d0fdea23bca2a9f5278fa067
Reviewed-on: https://chromium-review.googlesource.com/c/1352162
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611665}
[modify] https://crrev.com/d005f15952bb6b8fd91c233b90a533f3017185a0/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
[modify] https://crrev.com/d005f15952bb6b8fd91c233b90a533f3017185a0/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/d005f15952bb6b8fd91c233b90a533f3017185a0/content/browser/appcache/appcache_request_handler.cc
[modify] https://crrev.com/d005f15952bb6b8fd91c233b90a533f3017185a0/extensions/browser/api/declarative/rules_registry_service.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b92a3f8b64955204c84b4a100d4acaecd36fa4b

commit 9b92a3f8b64955204c84b4a100d4acaecd36fa4b
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Nov 28 15:50:59 2018

Remove obsolete TODO(vabr) from tab specific settings

There are a few TODOs in the code related to tab specific settings
left from the time of componentising them. Those TODOs were related to
planned structural changes in the code, which did not happen in the
end and did not block the componentisation.

Those TODOs are unlikely to provide any value in the future, so this
CL removes them.

Bug:  387075 ,  908813 
Change-Id: Iba5f2600d1a025cf4531c5ca0dbfb6b3fd269789
Reviewed-on: https://chromium-review.googlesource.com/c/1352352
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611708}
[modify] https://crrev.com/9b92a3f8b64955204c84b4a100d4acaecd36fa4b/chrome/browser/content_settings/tab_specific_content_settings.h
[modify] https://crrev.com/9b92a3f8b64955204c84b4a100d4acaecd36fa4b/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/9b92a3f8b64955204c84b4a100d4acaecd36fa4b/components/content_settings/core/browser/content_settings_utils.h
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9048a12229613332a19220e7fab4a4498f85a5e0

commit 9048a12229613332a19220e7fab4a4498f85a5e0
Author: Vaclav Brozek <vabr@chromium.org>
Date: Fri Nov 30 08:11:50 2018

Remove vabr@ from WATCHLISTS

vabr@ going hobby-only and being no longer OWNER after
https://crrev.com/c/1354009 will no longer need the CL updates.

Bug:  908813 

Change-Id: I5348adbee43a4137719e9c38fe255ec2654ce053
Reviewed-on: https://chromium-review.googlesource.com/c/1356039
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612594}
[modify] https://crrev.com/9048a12229613332a19220e7fab4a4498f85a5e0/WATCHLISTS
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/defc3a17c32c005efef570c6ba779eb05aa300e2

commit defc3a17c32c005efef570c6ba779eb05aa300e2
Author: Vaclav Brozek <vabr@chromium.org>
Date: Fri Nov 30 19:01:56 2018

Remove vabr@ from OWNERS

vabr@ leaves the Chrome team and will only be hobby-contributing in
the foreseeable future. Not being able to guarantee staying up to date
on the currently owned code, vabr@ is therefore removing himself from
all OWNERS files.

Notable changes:
* Adding dvadym@ to the OWNERS for password manager internals page,
  because he knows that code thoroughly and plans to enhance it soon.
* Adding a reference to components/password_manager/OWNERS to
  components/test/data/password_manager/OWNERS
* Adding cfroussios@ to third_party/libsecret/OWNERS, because of his
  work on code using this library.

R=cfroussios@chromium.org, dvadym@chromium.org, vasilii@chromium.org

Bug:  908813 
Change-Id: Id45989e6febe523a98f2b97730b82b80c5c29200
Reviewed-on: https://chromium-review.googlesource.com/c/1354009
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612715}
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/chrome/browser/password_manager/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/chrome/browser/profile_resetter/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/chrome/browser/ui/login/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/chrome/browser/ui/passwords/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/chrome/browser/ui/views/passwords/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/chrome/browser/ui/webui/password_manager_internals/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/chrome/renderer/autofill/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/components/autofill/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/components/autofill/content/renderer/OWNERS
[delete] https://crrev.com/cd7f1f8e6b94495acc668869789bcae171bc0d77/components/autofill/core/browser/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/components/autofill/core/common/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/components/password_manager/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/components/test/data/password_manager/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/ios/chrome/browser/passwords/OWNERS
[modify] https://crrev.com/defc3a17c32c005efef570c6ba779eb05aa300e2/third_party/libsecret/OWNERS

Comment 8 by vabr@chromium.org, Nov 30

Status: Fixed (was: Started)
►

Sign in to add a comment