New issue
Advanced search Search tips

Issue 908800 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 845079



Sign in to add a comment

Implement RWHVA::SetSelectionRange.

Project Member Reported by yhanada@chromium.org, Nov 27

Issue description

It's often used by Android IMEs.

We want to support the operation on browser windows.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb6386489c7e44a758c6f78554970cf970d0f66

commit cfb6386489c7e44a758c6f78554970cf970d0f66
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Thu Dec 13 10:16:35 2018

Add SetSelection to InputConnection interface.

This CL adds SetSelection method to InputConnection interface. It
provides the same functionality of InputConnection.SetSelection in
Android's InputConnection interface.

Bug:  908800 
Test: unit_tests
Change-Id: I8b4eb840e91b319ec196bce4a733868dc449db09
Reviewed-on: https://chromium-review.googlesource.com/c/1362778
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616260}
[modify] https://crrev.com/cfb6386489c7e44a758c6f78554970cf970d0f66/chrome/browser/chromeos/arc/input_method_manager/input_connection_impl.cc
[modify] https://crrev.com/cfb6386489c7e44a758c6f78554970cf970d0f66/chrome/browser/chromeos/arc/input_method_manager/input_connection_impl.h
[modify] https://crrev.com/cfb6386489c7e44a758c6f78554970cf970d0f66/chrome/browser/chromeos/arc/input_method_manager/input_connection_impl_unittest.cc
[modify] https://crrev.com/cfb6386489c7e44a758c6f78554970cf970d0f66/components/arc/common/input_method_manager.mojom
[modify] https://crrev.com/cfb6386489c7e44a758c6f78554970cf970d0f66/ui/base/ime/dummy_text_input_client.cc
[modify] https://crrev.com/cfb6386489c7e44a758c6f78554970cf970d0f66/ui/base/ime/dummy_text_input_client.h

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2bcc4086a602714ae69fcbdc883e409c7c7839

commit df2bcc4086a602714ae69fcbdc883e409c7c7839
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Mon Dec 17 11:36:40 2018

Implement RWHVA::SetEditableSelectionRange.

The operation is already implemented by FrameInputHandler, so the added
implementation just calls it.

Bug:  908800 , 915630
Change-Id: I19fdb51ac02e67fc94306448a8d3901ff8cbb56a
Reviewed-on: https://chromium-review.googlesource.com/c/1352076
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617086}
[modify] https://crrev.com/df2bcc4086a602714ae69fcbdc883e409c7c7839/content/browser/renderer_host/render_widget_host_view_aura.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0109cc4ca5d23a5033ea63543205553339ebf7d1

commit 0109cc4ca5d23a5033ea63543205553339ebf7d1
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Tue Dec 18 01:13:57 2018

Add MinVersion restriction to SetSelection.

I forgot to add it in crrev.com/c/1362778.

Bug:  908800 
Change-Id: I2c6b91261cbbaa6f542556f10d5e12c11be95ca2
Reviewed-on: https://chromium-review.googlesource.com/c/1378152
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617324}
[modify] https://crrev.com/0109cc4ca5d23a5033ea63543205553339ebf7d1/components/arc/common/input_method_manager.mojom

Status: Fixed (was: Assigned)

Sign in to add a comment