Regression:Theme credit message is seen on NTP even after applying custom background.
Reported by
vineetha...@etouch.net,
Nov 27
|
||||
Issue descriptionChrome Version: 72.0.3623.0 (Official Build) Revision bc6ec85849f003e7b403d5e48eee959e76de0cd3-refs/branch-heads/3623@{#1}(32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) Pre-Condition: 1.Enable 'Enable using the Google local NTP','New Tab Page Background Selection' and 'New Tab Page Custom Links' under chrome://flags 2.Apply the theme: Following are the sample theme URLs, a)https://chrome.google.com/webstore/detail/eiffel-tower-love-theme/ndkjfjdpgppkaocjfapgnapbeinkieng?utm_source=chrome-ntp-icon OR b)https://chrome.google.com/webstore/detail/marguerite-flowers/lipkgklkkoiammeadbcpmhbppdhaecdi?hl=en What steps will reproduce the problem? 1. Launch chrome, navigate to NTP (observe that the theme applied to chrome from web store has a theme credit message,appearing on lower RHS of NTP[Theme created by...]). 2. Now click on gear icon and apply any custom background. 3. Now observe the theme credit message on NTP. Actual : Theme credit message is seen on NTP even after applying custom background. Expected: Theme credit message should not be seen once custom background is applied. This is a regression issue, broken in M-71 series, and below is the per revision bisect info, Good Build : 71.0.3575.0(Revision:597883) Bad Build : 71.0.3576.0(Revision:598282) You are probably looking for a change made after 598111 (known good), but no later than 598112 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/9b61ffcad52233521a77c765c251bf8c7ccc4d80..0c2e94f782b4c855f9c9a94e7a9d3cf3d639f2b8 Suspect: https://chromium.googlesource.com/chromium/src/+/0c2e94f782b4c855f9c9a94e7a9d3cf3d639f2b8 @tgupta: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly review the screen-cast for reference Thank You!
,
Nov 27
,
Nov 28
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22ec81755f22cfa252e395b6b6ed4a746bda05f0 commit 22ec81755f22cfa252e395b6b6ed4a746bda05f0 Author: Kyle Milka <kmilka@chromium.org> Date: Wed Nov 28 22:39:42 2018 [NTP] Hide theme attribution when custom background is set If a custom background is set clear the theme attribution url. Bug: 908798 Change-Id: I2c612fa2fffaff04925a1f8d04d6b5962b0ccc4c Reviewed-on: https://chromium-review.googlesource.com/c/1354007 Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#611905} [modify] https://crrev.com/22ec81755f22cfa252e395b6b6ed4a746bda05f0/chrome/browser/ui/search/local_ntp_backgrounds_browsertest.cc [modify] https://crrev.com/22ec81755f22cfa252e395b6b6ed4a746bda05f0/chrome/renderer/searchbox/searchbox_extension.cc [add] https://crrev.com/22ec81755f22cfa252e395b6b6ed4a746bda05f0/chrome/test/data/extensions/theme_with_attribution/images/theme_frame_snow.png [add] https://crrev.com/22ec81755f22cfa252e395b6b6ed4a746bda05f0/chrome/test/data/extensions/theme_with_attribution/images/theme_ntp_background.png [add] https://crrev.com/22ec81755f22cfa252e395b6b6ed4a746bda05f0/chrome/test/data/extensions/theme_with_attribution/images/theme_toolbar_snow.png [add] https://crrev.com/22ec81755f22cfa252e395b6b6ed4a746bda05f0/chrome/test/data/extensions/theme_with_attribution/manifest.json
,
Nov 28
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ramyan@chromium.org
, Nov 27Labels: -Pri-1 -Target-71 KR-NTP-MD2-Polish O-Polish-Birthday-Features Pri-3
Owner: kmilka@chromium.org