Regression: [NTP] Thumbnail titles are seen chopped on increasing the minimum font size.
Reported by
sanyam.g...@etouch.net,
Nov 27
|
|||||||
Issue descriptionChrome Version: 72.0.3623.0 (Official Build) Revision bc6ec85849f003e7b403d5e48eee959e76de0cd3-refs/branch-heads/3623@{#1} (32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.13.6, 10.13.1, 10.14.2),Linux(14.04 LTS) Pre-Condition:Enable 'Enable using the Google local NTP' and 'New Tab Page Custom Links' under chrome://flags What steps will reproduce the problem? 1. Launch chrome, navigate to ‘chrome://settings/fonts’ and change the minimum font size to ‘Huge’. 2. Add shortcut and observe the thumbnail Titles. Actual : Thumbnail titles are seen chopped on increasing the minimum font size. Expected: Thumbnail titles should not be seen chopped on increasing the minimum font size. This is a regression issue, broken in M-72 series, and below is the per-revision-bisect-info Good Build : 72.0.3622.0 (Revision:610747) Bad Build : 72.0.3623.0 (Revision:611016) You are probably looking for a change made after 610940 (known good), but no later than 610941 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/753b30fdc46bc635b653829ae9c0053422a2d7e2..a1ac4a78172b6a621a436cc8dcd281ee7ab3c138 Suspect: https://chromium.googlesource.com/chromium/src/+/a1ac4a78172b6a621a436cc8dcd281ee7ab3c138 @Kristi: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly review the screen-cast for reference Thank You!
,
Nov 27
,
Nov 27
,
Nov 28
,
Nov 29
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75702140481df09e0e911c8e08e8d663ee3f8ed7 commit 75702140481df09e0e911c8e08e8d663ee3f8ed7 Author: Tina Wang <tinazwang@chromium.org> Date: Fri Nov 30 17:49:01 2018 Fixed thumbnail title cropping Added span tag inside title div to ensure: - the minimum height of title will be 24px, - the theme pills won't shrink size when font size is small Deleted the height and line-height properties in md-title style to: - let the span keep the min height - let the line-height increase automatically when choosing huge font size Bug: 908792 Change-Id: I75f5ab0b39ddc760115b2dfa8ea013adee490e2b Reviewed-on: https://chromium-review.googlesource.com/c/1354356 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#612689} [modify] https://crrev.com/75702140481df09e0e911c8e08e8d663ee3f8ed7/chrome/browser/resources/local_ntp/most_visited_single.css [modify] https://crrev.com/75702140481df09e0e911c8e08e8d663ee3f8ed7/chrome/browser/resources/local_ntp/most_visited_single.js
,
Nov 30
,
Nov 30
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kristip...@chromium.org
, Nov 27Status: Started (was: Assigned)