New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 908782 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Clear All animation is partially broken

Project Member Reported by tetsui@chromium.org, Nov 27

Issue description

Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Create many notifications so that it maxes out
(2) Open System Tray
(3) Click on the Clear All button

What is the expected result?
The Clear All animation should be smoothly shown.

What happens instead?
The first phase of the animation is broken. See the attached viewo.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
IMG_2487.MOV
2.1 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1508c61f10785ea9737954903f2b46e98c88f2d

commit e1508c61f10785ea9737954903f2b46e98c88f2d
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Nov 28 02:03:44 2018

Stop unexpected animation during CLEAR_ALL_STACKED

Clear all notification animation consists of two phases:
CLEAR_ALL_STACKED and CLEAR_ALL_VISIBLE.

During CLEAR_ALL_STACKED phase, only the counter at the top should
animate, so each notification should not move even though
GetCurrentValue() might not return 1.0.
See the bug for detail.

TEST=UnifiedMessageListViewTest.ClearAllWithStackingNotifications
BUG= 908782 

Change-Id: I24f369753cc17ad761d85c654743504a07e9e148
Reviewed-on: https://chromium-review.googlesource.com/c/1352111
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611510}
[modify] https://crrev.com/e1508c61f10785ea9737954903f2b46e98c88f2d/ash/system/message_center/unified_message_list_view.cc
[modify] https://crrev.com/e1508c61f10785ea9737954903f2b46e98c88f2d/ash/system/message_center/unified_message_list_view_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment