New issue
Advanced search Search tips

Issue 908772 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

authpolicy: Backup user realm

Project Member Reported by ljusten@chromium.org, Nov 27

Issue description

If authpolicyd is restarted mid-session and a policy fetch is triggered, it runs into a CHECK since the user realm is not backed up and restored, see SambaInterface::FetchUserGpos().

The user realm should be backed up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0e13196fa4fbc11b0e7efc7b02948e35d36ce737

commit 0e13196fa4fbc11b0e7efc7b02948e35d36ce737
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Nov 27 19:23:16 2018

authpolicy: Back up and restore user realm

If authpolicyd is restarted mid-session for some reason (manually or due
to a crash), and the user triggers a policy fetch, authpolicyd runs into
a CHECK in SambaInterface::FetchUserGpos() since the user realm is not
backed up and restored. This CL adds this as well as a regression test.

BUG= chromium:908772 
TEST=On a Chromad device, log in, open console, type 'restart
     authpolicyd', open Chrome, go to chrome://policy, click "Reload
     policies", check /var/log/authpolicyd. It should NOT say
     "Check failed: !user_account_.realm.empty()".

Change-Id: Ic08f52d751b46983a2becb8407b319598a91f90f
Reviewed-on: https://chromium-review.googlesource.com/1352169
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/0e13196fa4fbc11b0e7efc7b02948e35d36ce737/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/0e13196fa4fbc11b0e7efc7b02948e35d36ce737/authpolicy/samba_interface.cc
[modify] https://crrev.com/0e13196fa4fbc11b0e7efc7b02948e35d36ce737/authpolicy/proto/authpolicy_containers.proto

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified fixed, after 'restart authpolicyd' and "Reload policies", there is no "Check failed: !user_account_.realm.empty()" in /var/log/authpolicy.log.

Chrome OS: 11348.0.0, Chrome: 73.0.3629.0, Device: Nautilus

Attached authpolicy.log
authpolicy.log
10.5 KB View Download

Sign in to add a comment