New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 908771 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Flaky on Windows: TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex

Project Member Reported by tschumann@google.com, Nov 27

Issue description

actually, the dashboard might be tricking me -- I couldn't see the failure logs for that test on a win10_chromium_x64_rel_ng bot. 

Will disable the asan test.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52a2c835e3a2ca8a2de17eda96243ab44c89de86

commit 52a2c835e3a2ca8a2de17eda96243ab44c89de86
Author: Tim Schumann <tschumann@chromium.org>
Date: Tue Nov 27 13:20:14 2018

Disable flaky sync integration test on win-asan.

Test case: TwoClientBookmarksSyncTestIncludingUssTests.MC_MergeDifferentBMModelsModeratelyComplex

Bug: 908771
Change-Id: Ibf0166436b5639caaeb5583a3a6b7ab541e3cd9c
Reviewed-on: https://chromium-review.googlesource.com/c/1352129
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611087}
[modify] https://crrev.com/52a2c835e3a2ca8a2de17eda96243ab44c89de86/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

Cc: tschumann@chromium.org
Labels: -Sheriff-Chromium
Cc: jkrcal@chromium.org
Labels: Pri-1
On 1/11 this test flaked 18 times on mac_chromium_rel_ng. This is one of the top sources of flake in the chromium code base.
Mohamed, could you fix that or disable it overall? 

The tsan failures are due to  Issue 917380  (should be fixed later today) but the rest is due to the test itself...
Status: Assigned (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83eaf17dea58f44398cdcfa0c3910cbfbf4a3de5

commit 83eaf17dea58f44398cdcfa0c3910cbfbf4a3de5
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Mon Jan 14 11:02:21 2019

[Sync:USS] Disable flaky  MC_MergeDifferentBMModelsModeratelyComplex

Test was diabled only on win-asan. However, recently it became
falky almost everywhere.

Bug: 908771
Change-Id: I24fafa198c3c63b0f6f2cb7f1dc15a928e886d32
Reviewed-on: https://chromium-review.googlesource.com/c/1408912
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622417}
[modify] https://crrev.com/83eaf17dea58f44398cdcfa0c3910cbfbf4a3de5/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

Comment 9 by jkrcal@chromium.org, Yesterday (43 hours ago)

Labels: -Pri-1 Pri-2
Mohamed, I decreased prio to P2 (for fixing the cause of the flakiness). If no more work is actually needed, please close the bug.

Sign in to add a comment