New issue
Advanced search Search tips

Issue 908756 link

Starred by 1 user
Status: Assigned
Owner:
toyoshim@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

OOR-CORS: fix OriginAccessList internal design

Project Member Reported by toyoshim@chromium.org, Nov 27 
Now OriginAccessList has separate origin-pattern maps for allow/block lists. On the other hand, mojom::CorsOriginAccessPatterns has a single map which key is origin, but has both patterns as its value.

mojom::CorsOriginAccessPatterns design is aligned with NetworkContext APIs and real use cases. So, I'd modify OriginAccessList internal impl to have the same design.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f105984120b4b564105d5e41257a73d8ab106cf

commit 7f105984120b4b564105d5e41257a73d8ab106cf
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Nov 28 08:49:52 2018

OOR-CORS: Use CorsOriginAccessMatchMode in CorsOriginPattern

This patch makes mojom::CorsOriginPattern use CorsORiginAccessMatchMode
and allows network::cors::OriginAccessList to create equivalent
mojom::CorsOriginAccessPatterns array.

Also this patch enforces not to rely on cors_origin_patterns.mojom.h
indirectly from Blink platform.

Bug:  908324 , 908756
Change-Id: If059a460b424025376b2e4d4433ba6ec17523357
Reviewed-on: https://chromium-review.googlesource.com/c/1350689
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611603}
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/chrome/common/extensions/chrome_extensions_client.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/content/browser/loader/cors_origin_access_list_browsertest.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/extensions/common/cors_util.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_entry.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_entry.h
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_entry_unittest.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_list.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_list.h
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/cpp/cors/origin_access_list_unittest.cc
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/services/network/public/mojom/cors_origin_pattern.mojom
[modify] https://crrev.com/7f105984120b4b564105d5e41257a73d8ab106cf/third_party/blink/renderer/platform/weborigin/security_policy.cc
►

Sign in to add a comment