pipeThrough should brand-check its arguments |
|||
Issue descriptionhttps://github.com/whatwg/streams/pull/966 updated the behaviour of pipeThrough() to have a brand check. This now matches what Chrome does since https://chromium-review.googlesource.com/c/1322172, however the standard added additional requirement that pipeThough: * Brand check |readable| and |writable| * Throw if |readable| or |writable| is locked * Throw if |signal| is defined and not an AbortSignal.
,
Dec 3
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/024e9652ac308a90cc038aaf73d50b73ac4d24bf commit 024e9652ac308a90cc038aaf73d50b73ac4d24bf Author: Adam Rice <ricea@chromium.org> Date: Tue Dec 04 10:11:46 2018 Update the checks performed by pipeThrough() pipeThrough() now performs the same checks as required by the standard, with the exception of the check for the "signal" option. Aborting pipes is not supported yet, so the signal option will not be checked until it is. Exceptions are thrown for failed checks, making errors easier to diagnose. BUG= 908747 Change-Id: I8a087f1c087a671ed484bca79828651a142ed571 Reviewed-on: https://chromium-review.googlesource.com/c/1356722 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#613494} [modify] https://crrev.com/024e9652ac308a90cc038aaf73d50b73ac4d24bf/third_party/blink/renderer/core/streams/readable_stream.cc [modify] https://crrev.com/024e9652ac308a90cc038aaf73d50b73ac4d24bf/third_party/blink/web_tests/external/wpt/streams/piping/pipe-through.any-expected.txt [modify] https://crrev.com/024e9652ac308a90cc038aaf73d50b73ac4d24bf/third_party/blink/web_tests/external/wpt/streams/piping/pipe-through.any.serviceworker-expected.txt [modify] https://crrev.com/024e9652ac308a90cc038aaf73d50b73ac4d24bf/third_party/blink/web_tests/external/wpt/streams/piping/pipe-through.any.sharedworker-expected.txt [modify] https://crrev.com/024e9652ac308a90cc038aaf73d50b73ac4d24bf/third_party/blink/web_tests/external/wpt/streams/piping/pipe-through.any.worker-expected.txt
,
Jan 11
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ricea@chromium.org
, Nov 28